Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reject empty checkout #770

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

csandru-plenty
Copy link
Contributor

@csandru-plenty csandru-plenty commented Oct 30, 2024

Why:

Closes: AB#131753

Describe your changes

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@csandru-plenty csandru-plenty self-assigned this Oct 30, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 30, 2024
@csandru-plenty csandru-plenty marked this pull request as ready for review October 30, 2024 13:50
@csandru-plenty csandru-plenty requested a review from a team as a code owner October 30, 2024 13:50
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 30, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 30, 2024
@maxiroellplenty
Copy link
Contributor

Very clean implementation, love the middleware and the clean isCartEmpty usage, great work 💪

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 30, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 31, 2024
@csandru-plenty csandru-plenty enabled auto-merge (squash) October 31, 2024 07:55
@csandru-plenty csandru-plenty merged commit e69f256 into main Oct 31, 2024
7 checks passed
@csandru-plenty csandru-plenty deleted the feat/reject-empty-checkout branch October 31, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants