Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: geo blocking regulation #709

Merged
merged 17 commits into from
Oct 28, 2024
Merged

feat: geo blocking regulation #709

merged 17 commits into from
Oct 28, 2024

Conversation

csandru-plenty
Copy link
Contributor

@csandru-plenty csandru-plenty commented Oct 2, 2024 •
edited by plenty-to-azure
Loading

Why:

Closes: AB#127685

Describe your changes

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@csandru-plenty csandru-plenty self-assigned this Oct 2, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 2, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 24, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 24, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 24, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 24, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 24, 2024
@github-actions github-actions bot removed the feature New feature or request label Oct 24, 2024
@csandru-plenty csandru-plenty marked this pull request as ready for review October 24, 2024 12:32
@github-actions github-actions bot added the feature New feature or request label Oct 24, 2024
@csandru-plenty csandru-plenty requested a review from a team as a code owner October 24, 2024 12:32
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 24, 2024
@github-actions github-actions bot removed the feature New feature or request label Oct 24, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 24, 2024
maxiroellplenty
maxiroellplenty requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@maxiroellplenty maxiroellplenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we change it so that the state data uses the default and geoRegulated with the empty array as a default, we can avoid the length checks right?

apps/web/composables/useAggregatedCountries/useAggregatedCountries.ts Outdated Show resolved Hide resolved
apps/web/composables/useAddressV2/useFetchAddress.ts Show resolved Hide resolved
apps/web/composables/useAggregatedCountries/useAggregatedCountries.ts Outdated Show resolved Hide resolved
apps/web/composables/useAddressForm/useAddressForm.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 25, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 25, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 28, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 28, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 28, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 28, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 28, 2024
@csandru-plenty csandru-plenty enabled auto-merge (squash) October 28, 2024 13:46
@csandru-plenty csandru-plenty merged commit b2c6b75 into main Oct 28, 2024
6 checks passed
@csandru-plenty csandru-plenty deleted the feat/geo-blocking-regulation branch October 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxiroellplenty maxiroellplenty maxiroellplenty approved these changes

Assignees

@csandru-plenty csandru-plenty

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csandru-plenty @maxiroellplenty