Redirect users to the intended page after successful login #672
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjementum
changed the title
tjementum
force-pushed
the
pp-302-use-returnpath-as-the-destination-when-logging-in
branch
from
9a920e4 to
78cbeee
Compare
|
tjementum
deleted the
pp-302-use-returnpath-as-the-destination-when-logging-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Improve the login flow by redirecting users to the page they were attempting to access before being prompted to log in. For example, if a user tries to visit
/admin/userswithout being logged in, they are redirected to the login page with?returnPath=%2Fadmin%2Fusersin the URL. After logging in, the user is redirected back to/admin/users.To ensure security, redirects to different domains are explicitly blocked. Only
returnPathvalues starting with/are allowed, preventing open redirect vulnerabilities.Checklist