Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Application Insights tracking with user-specific properties and simplified event naming #618

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

tjementum
Copy link
Member

Summary & Motivation

Update Application Insights tracking for custom events by adding user-specific properties such as UserId, TenantId, Local, UserRole, and IsAuthenticated. These properties are prefixed with user_ (e.g., user_Local, user_IsAuthenticated) by convention, ensuring consistency and enhancing the clarity of user-related data in telemetry.

The creation of telemetry events has also been simplified to reduce errors. Event names are now derived using GetType().Name instead of nameof(EventName), avoiding issues from copy-pasting, such as when UserUpdated events were incorrectly named as UserCreated.

Additionally, telemetry tracking is now updated to collect UserId and TenantId specifically in unauthenticated login flows and admin role changes, ensuring precise event data collection for critical user actions.

Checklist

  • I have added a Label to the pull-request
  • I have added tests, and done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Enhancement New feature or request label Nov 7, 2024
@tjementum tjementum self-assigned this Nov 7, 2024
Copy link

linear bot commented Nov 7, 2024

Copy link

sonarqubecloud bot commented Nov 7, 2024

@tjementum tjementum merged commit f7d1b2b into main Nov 7, 2024
13 checks passed
@tjementum tjementum deleted the pp-236-telemetry-events-optimizations branch November 7, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant