Skip to content

Commit

Permalink
Change liveness and readiness health probes scheme from HTTPS to HTTP (
Browse files Browse the repository at this point in the history
…#529)

### Summary & Motivation

Change liveness and readiness health probes scheme from HTTPS to HTTP.
In a previous pull request, we switched from TCP to HTTP health probes
for the API in Azure Container App. However, these failed to start
because the scheme was set to HTTPS instead of HTTP. This PR corrects
the scheme to HTTP, ensuring proper functionality.

### Checklist

- [x] I have added a Label to the pull-request
- [x] I have added tests, and done manual regression tests
- [x] I have updated the documentation, if necessary
  • Loading branch information
tjementum authored Jul 8, 2024
2 parents 7cd2305 + c2f9eba commit c505dbd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cloud-infrastructure/modules/container-app.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ resource containerApp 'Microsoft.App/containerApps@2023-05-02-preview' = {
httpGet: {
path: '/internal-api/live'
port: 8080
scheme: 'HTTPS'
scheme: 'HTTP'
}
initialDelaySeconds: 3
failureThreshold: 3
Expand All @@ -114,7 +114,7 @@ resource containerApp 'Microsoft.App/containerApps@2023-05-02-preview' = {
httpGet: {
path: '/internal-api/ready'
port: 8080
scheme: 'HTTPS'
scheme: 'HTTP'
}
initialDelaySeconds: 3
failureThreshold: 3
Expand All @@ -125,7 +125,7 @@ resource containerApp 'Microsoft.App/containerApps@2023-05-02-preview' = {
]
: [
{
type: 'liveness'
type: 'Liveness'
failureThreshold: 3
periodSeconds: 10
successThreshold: 1
Expand All @@ -135,7 +135,7 @@ resource containerApp 'Microsoft.App/containerApps@2023-05-02-preview' = {
timeoutSeconds: 1
}
{
type: 'readiness'
type: 'Readiness'
failureThreshold: 48
initialDelaySeconds: 3
periodSeconds: 5
Expand Down

0 comments on commit c505dbd

Please sign in to comment.