fix Assertion failed: pkgx: env is being duped when multiple unicodes in env
#989
Conversation
…es in env closes #988
dosubot
bot
added
the
size:S
mxcl
force-pushed
the
main
branch
2 times, most recently
from
9038067
to
342373c
Compare
| @@ -36,7 +36,7 @@ export default async function(pkgenv: { installations: Installation[] }) { | |||
|
|
|||
| ///////////////////////// reworked from useShellEnv needs porting back to libpkgx | |||
| async function mkenv({installations}: {installations: Installation[]}) { | |||
| const projects = new Set(installations.map(x => x.pkg.project)) | |||
| const projects = new Set(installations.map(x => `${x.pkg.project}@${x.pkg.version}`)) | |||
There was a problem hiding this comment.
Can't remember why we added this anyway.
There was a problem hiding this comment.
it's been a while, but i believe it's because we can allow multiple unicode lib versions in the env simultaneously, and this check trips if there are two or more (since they map to the same name).
unless you mean the dupe-check; in which case, i'm sure it's sanity checking. definitely a good idea with how complex the env can get.
There was a problem hiding this comment.
I seem to recall there was an issue if an env had multiple of the same exact thing but can't remember.
There was a problem hiding this comment.
i do recall at one point early on we would sometimes get the pkg@ver duplicated; perhaps this was to ensure that bug never returned.
closes #988