Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pantry not found on first execution #670

Closed
wants to merge 1 commit into from

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Jul 31, 2023

Fixes #664

@what-the-diff
Copy link

what-the-diff bot commented Jul 31, 2023

PR Summary

  • Introduction of New Error Handling
    Imported a specific error type named PantryNotFoundError from the "tea" module into the main app file. This would help in more specialized error management.

  • Improved Exception Handling in the Main App
    The run function which carries out core app operations now has enhanced exception handling. A try-catch block has been introduced, which means that the app will try to perform its operations and if an error occurs, it will catch and handle it gracefully. This is aided by a new variable shouldSync, whose value is adjusted according to certain conditions for better error control.

@mxcl
Copy link
Member

mxcl commented Jul 31, 2023

Thank you! However I am fixing this in libtea since I consider it a bug there. Sorry you wasted the time :/

pkgxdev/libpkgx@befdbbb

@mxcl mxcl closed this Jul 31, 2023
@mxcl
Copy link
Member

mxcl commented Jul 31, 2023

will release a fix within couple hours. Waiting on CI

@felipecrs felipecrs deleted the fix-pantry-not-found branch July 31, 2023 21:04
@felipecrs
Copy link
Contributor Author

Your fix is much cleaner, it makes sense. And it's not wasted time at all, I'm in love with Tea. :)

Thank you!

@mxcl
Copy link
Member

mxcl commented Aug 1, 2023

sorry, CI was backed up and I went to sleep, PR up and will merge when it passes

@mxcl
Copy link
Member

mxcl commented Aug 1, 2023

v0.39.5 out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically --sync when needed
2 participants