Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tea --magic=install; tea --magic=uninstall #646

Merged
merged 2 commits into from
Jul 25, 2023
Merged

tea --magic=install; tea --magic=uninstall #646

merged 2 commits into from
Jul 25, 2023

Conversation

mxcl
Copy link
Member

@mxcl mxcl commented Jul 25, 2023

I don't like the ergonomics of --magic=install but it was quick n’ easy. Will revise when I have better ideas

@what-the-diff
Copy link

what-the-diff bot commented Jul 25, 2023

PR Summary

  • Upgradation of the CLI tool version
    The command-line interface tool 'tea' used for managing tasks has been updated, enhancing its capacities with the latest version (from 0.38.4 to 0.39.0).

  • Incorporation of a new command
    A fresh instruction command tea node@16 --version has been introduced, which paves the way for checking the 'node' version easily.

  • Improvement in readability
    Some linguistic improvements were made in the instruction manual (README.md). These changes are designed to enhance clarity and comprehensibility for users.

  • Introduction of a new feature - 'magic'
    A new utility 'magic' has been introduced via app.magic.ts. It has the capability to make alterations (either installations or uninstallations) to shell rc files. This can be seen as a tool for managing shell rc files more efficiently.

  • Usage of the new 'magic' feature
    The main application (app.main.ts) has been revised to utilize the 'magic' feature for install or uninstall modes. This allows users to efficiently manage their modes of usage for this tool.

@mxcl mxcl requested review from ABevier and jhheider and removed request for ABevier July 25, 2023 16:08
@jhheider
Copy link
Contributor

--add and --rm?

Copy link
Contributor

@jhheider jhheider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane. Better for shell switchers.

src/app.magic.ts Outdated Show resolved Hide resolved
src/app.magic.ts Outdated Show resolved Hide resolved
@mxcl
Copy link
Member Author

mxcl commented Jul 25, 2023

I considered a --magic that “magically” determines shell (by testing syntax or magic variables), but it's not worth it probs.

As it stands if you don't specify =shell we determine it by inspecting $SHELL however it turns out this may be wrong or unset. There's no POSIX standard for determining shell. You can try to inspect the process tree and (for sure) that's what ChatGPT wants us to do.


This aside is somewhat irrelevant as this PR just adds magic to any files we can find that we support.

@mxcl mxcl merged commit 5ccadde into main Jul 25, 2023
6 checks passed
@mxcl mxcl deleted the magic-install branch July 25, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants