-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix regression in construct-env.ts #1037
Conversation
Pull Request Test Coverage Report for Build 10836081568Details
💛 - Coveralls |
I'm confused how this fixes things. If the assert was triggering before how were builds still continuing with a reduced env? |
the assertions weren't triggering except in maybe 1 build (maybe? or zero.) but were preventing things like postgres and node from working in the same env. however, the fix basically broke |
I'll merge but still confused as to how it had affects |
ugh. that's that same species of incomplete env.... let me see if building from scratch does that on docker. 1.2.0 works fine (run by hand) |
both |
even |
pkgx/pkgx $ ./pkgx +gnupg.org | grep LD_LIB | tr : '\n' | grep readline
/root/.pkgx/gnu.org/readline/v8.2.13/lib |
yeah only fails for linux aarch64 and well, it's using the just built |
The draft release could just be released without linux aarch64 since like, it's the least interesting platform |
i can't prove it, but the only thing that changed for deps is the sync cache. so, db corruption, or an incomplete await, or something could have short data. but deleting the deps in my pantry.db doesn't even affect my local invocation, so that's more mysterious. it's odd that the fact that it's only messing up the LD_LIBRARY_PATH on linuxen is also concerning. |
you know, the runners aren't clearing ~/.cache/pkgx; maybe I update their script and see. |
that fixed it immediately. so it's cache corruption. fun. i bet |
couldn't be that easy, i guess: https://github.com/pkgxdev/pantry/actions/runs/10820951092/job/30130754367?pr=7239 |
If you can |
Maybe downgrade |
$ builder@f8b90684f45a:/$ pkgx +php.net +gnu.org/gcc/libstdcxx
CPATH="/home/builder/.pkgx/zlib.net/v1.3.1/include:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/include:/home/builder/.pkgx/facebook.com/zstd/v1.5.6/include:/home/builder/.pkgx/pcre.org/v2/v10.44.0/include:/home/builder/.pkgx/unicode.org/v71.1.0/include:/home/builder/.pkgx/sqlite.org/v3.46.1/include:/home/builder/.pkgx/curl.se/v8.10.0/include:/home/builder/.pkgx/sourceware.org/libffi/v3.4.6/include:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/include:/home/builder/.pkgx/tukaani.org/xz/v5.6.2/include:/home/builder/.pkgx/simplesystems.org/libtiff/v4.6.0/include:/home/builder/.pkgx/libjpeg-turbo.org/v2.1.5.1/include:/home/builder/.pkgx/gnu.org/readline/v8.2.13/include:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/include:/home/builder/.pkgx/libsodium.org/v1.0.18/include:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/include:/home/builder/.pkgx/gnome.org/libxml2/v2.11.9/include:/home/builder/.pkgx/invisible-island.net/ncurses/v6.4.0/include:/home/builder/.pkgx/openssl.org/v1.1.1w/include:/home/builder/.pkgx/giflib.sourceforge.io/v5.2.2/include:/home/builder/.pkgx/gnu.org/gettext/v0.22.5/include:/home/builder/.pkgx/libpng.org/v1.6.44/include:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/include:/home/builder/.pkgx/gnu.org/gcc/libstdcxx/v14.2.0/include:/home/builder/.pkgx/lz4.org/v1.10.0/include:/home/builder/.pkgx/sourceware.org/bzip2/v1.0.8/include:/home/builder/.pkgx/libzip.org/v1.9.2/include:/home/builder/.pkgx/gnome.org/libxslt/v1.1.42/include:/home/builder/.pkgx/ijg.org/v9f/include:/home/builder/.pkgx/gnu.org/libiconv/v1.17.0/include:/home/builder/.pkgx/apache.org/apr-util/v1.6.3/include:/home/builder/.pkgx/kerberos.org/v1.21.3/include:/home/builder/.pkgx/thrysoee.dk/editline/v3.1.0/include:/home/builder/.pkgx/apache.org/apr/v1.7.5/include:/home/builder/.pkgx/php.net/v8.3.11/include:/home/builder/.pkgx/github.com/kkos/oniguruma/v6.9.9/include:/home/builder/.pkgx/google.com/webp/v1.4.0/include${CPATH:+:$CPATH}"
LIBRARY_PATH="/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/facebook.com/zstd/v1.5.6/lib:/home/builder/.pkgx/pcre.org/v2/v10.44.0/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/sqlite.org/v3.46.1/lib:/home/builder/.pkgx/curl.se/v8.10.0/lib:/home/builder/.pkgx/perl.org/v5.40.0/lib:/home/builder/.pkgx/sourceware.org/libffi/v3.4.6/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/tukaani.org/xz/v5.6.2/lib:/home/builder/.pkgx/simplesystems.org/libtiff/v4.6.0/lib:/home/builder/.pkgx/libjpeg-turbo.org/v2.1.5.1/lib:/home/builder/.pkgx/gnu.org/readline/v8.2.13/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/libsodium.org/v1.0.18/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/bison/v3.8.2/lib:/home/builder/.pkgx/gnome.org/libxml2/v2.11.9/lib:/home/builder/.pkgx/invisible-island.net/ncurses/v6.4.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/giflib.sourceforge.io/v5.2.2/lib:/home/builder/.pkgx/gnu.org/gettext/v0.22.5/lib:/home/builder/.pkgx/libpng.org/v1.6.44/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/libstdcxx/v14.2.0/lib:/home/builder/.pkgx/lz4.org/v1.10.0/lib:/home/builder/.pkgx/sourceware.org/bzip2/v1.0.8/lib:/home/builder/.pkgx/libzip.org/v1.9.2/lib:/home/builder/.pkgx/gnome.org/libxslt/v1.1.42/lib:/home/builder/.pkgx/ijg.org/v9f/lib:/home/builder/.pkgx/gnu.org/libiconv/v1.17.0/lib:/home/builder/.pkgx/apache.org/apr-util/v1.6.3/lib:/home/builder/.pkgx/kerberos.org/v1.21.3/lib:/home/builder/.pkgx/thrysoee.dk/editline/v3.1.0/lib:/home/builder/.pkgx/apache.org/apr/v1.7.5/lib:/home/builder/.pkgx/php.net/v8.3.11/lib:/home/builder/.pkgx/github.com/kkos/oniguruma/v6.9.9/lib:/home/builder/.pkgx/google.com/webp/v1.4.0/lib${LIBRARY_PATH:+:$LIBRARY_PATH}"
PKG_CONFIG_PATH="/home/builder/.pkgx/zlib.net/v1.3.1/lib/pkgconfig:/home/builder/.pkgx/facebook.com/zstd/v1.5.6/lib/pkgconfig:/home/builder/.pkgx/pcre.org/v2/v10.44.0/lib/pkgconfig:/home/builder/.pkgx/unicode.org/v71.1.0/lib/pkgconfig:/home/builder/.pkgx/sqlite.org/v3.46.1/lib/pkgconfig:/home/builder/.pkgx/curl.se/v8.10.0/lib/pkgconfig:/home/builder/.pkgx/sourceware.org/libffi/v3.4.6/lib/pkgconfig:/home/builder/.pkgx/tukaani.org/xz/v5.6.2/lib/pkgconfig:/home/builder/.pkgx/simplesystems.org/libtiff/v4.6.0/lib/pkgconfig:/home/builder/.pkgx/libjpeg-turbo.org/v2.1.5.1/lib/pkgconfig:/home/builder/.pkgx/gnu.org/readline/v8.2.13/lib/pkgconfig:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib/pkgconfig:/home/builder/.pkgx/libsodium.org/v1.0.18/lib/pkgconfig:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib/pkgconfig:/home/builder/.pkgx/gnome.org/libxml2/v2.11.9/lib/pkgconfig:/home/builder/.pkgx/invisible-island.net/ncurses/v6.4.0/lib/pkgconfig:/home/builder/.pkgx/openssl.org/v1.1.1w/lib/pkgconfig:/home/builder/.pkgx/libpng.org/v1.6.44/lib/pkgconfig:/home/builder/.pkgx/lz4.org/v1.10.0/lib/pkgconfig:/home/builder/.pkgx/libzip.org/v1.9.2/lib/pkgconfig:/home/builder/.pkgx/gnome.org/libxslt/v1.1.42/lib/pkgconfig:/home/builder/.pkgx/ijg.org/v9f/lib/pkgconfig:/home/builder/.pkgx/apache.org/apr-util/v1.6.3/lib/pkgconfig:/home/builder/.pkgx/kerberos.org/v1.21.3/lib/pkgconfig:/home/builder/.pkgx/thrysoee.dk/editline/v3.1.0/lib/pkgconfig:/home/builder/.pkgx/apache.org/apr/v1.7.5/lib/pkgconfig:/home/builder/.pkgx/github.com/kkos/oniguruma/v6.9.9/lib/pkgconfig:/home/builder/.pkgx/google.com/webp/v1.4.0/lib/pkgconfig${PKG_CONFIG_PATH:+:$PKG_CONFIG_PATH}"
XDG_DATA_DIRS="/home/builder/.pkgx/zlib.net/v1.3.1/share:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/share:/home/builder/.pkgx/facebook.com/zstd/v1.5.6/share:/home/builder/.pkgx/pcre.org/v2/v10.44.0/share:/home/builder/.pkgx/unicode.org/v71.1.0/share:/home/builder/.pkgx/sqlite.org/v3.46.1/share:/home/builder/.pkgx/curl.se/v8.10.0/share:/home/builder/.pkgx/gnu.org/m4/v1.4.19/share:/home/builder/.pkgx/sourceware.org/libffi/v3.4.6/share:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/share:/home/builder/.pkgx/tukaani.org/xz/v5.6.2/share:/home/builder/.pkgx/simplesystems.org/libtiff/v4.6.0/share:/home/builder/.pkgx/libjpeg-turbo.org/v2.1.5.1/share:/home/builder/.pkgx/gnu.org/readline/v8.2.13/share:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/share:/home/builder/.pkgx/gnu.org/sed/v4.9.0/share:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/share:/home/builder/.pkgx/gnu.org/bison/v3.8.2/share:/home/builder/.pkgx/gnome.org/libxml2/v2.11.9/share:/home/builder/.pkgx/invisible-island.net/ncurses/v6.4.0/share:/home/builder/.pkgx/giflib.sourceforge.io/v5.2.2/share:/home/builder/.pkgx/gnu.org/gettext/v0.22.5/share:/home/builder/.pkgx/libpng.org/v1.6.44/share:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/share:/home/builder/.pkgx/gnu.org/gcc/libstdcxx/v14.2.0/share:/home/builder/.pkgx/lz4.org/v1.10.0/share:/home/builder/.pkgx/libzip.org/v1.9.2/share:/home/builder/.pkgx/gnome.org/libxslt/v1.1.42/share:/home/builder/.pkgx/ijg.org/v9f/share:/home/builder/.pkgx/gnu.org/libiconv/v1.17.0/share:/home/builder/.pkgx/kerberos.org/v1.21.3/share:/home/builder/.pkgx/gnu.org/autoconf/v2.72.0/share:/home/builder/.pkgx/thrysoee.dk/editline/v3.1.0/share:/home/builder/.pkgx/re2c.org/v3.1.0/share:/home/builder/.pkgx/php.net/v8.3.11/share:/home/builder/.pkgx/google.com/webp/v1.4.0/share${XDG_DATA_DIRS:+:$XDG_DATA_DIRS}"
MANPATH="/home/builder/.pkgx/zlib.net/v1.3.1/share/man:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/share/man:/home/builder/.pkgx/facebook.com/zstd/v1.5.6/share/man:/home/builder/.pkgx/pcre.org/v2/v10.44.0/share/man:/home/builder/.pkgx/unicode.org/v71.1.0/share/man:/home/builder/.pkgx/sqlite.org/v3.46.1/share/man:/home/builder/.pkgx/curl.se/v8.10.0/share/man:/home/builder/.pkgx/gnu.org/m4/v1.4.19/share/man:/home/builder/.pkgx/sourceware.org/libffi/v3.4.6/share/man:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/share/man:/home/builder/.pkgx/tukaani.org/xz/v5.6.2/share/man:/home/builder/.pkgx/simplesystems.org/libtiff/v4.6.0/share/man:/home/builder/.pkgx/libjpeg-turbo.org/v2.1.5.1/share/man:/home/builder/.pkgx/gnu.org/readline/v8.2.13/share/man:/home/builder/.pkgx/gnu.org/sed/v4.9.0/share/man:/home/builder/.pkgx/gnu.org/bison/v3.8.2/share/man:/home/builder/.pkgx/gnome.org/libxml2/v2.11.9/share/man:/home/builder/.pkgx/invisible-island.net/ncurses/v6.4.0/share/man:/home/builder/.pkgx/giflib.sourceforge.io/v5.2.2/share/man:/home/builder/.pkgx/gnu.org/gettext/v0.22.5/share/man:/home/builder/.pkgx/libpng.org/v1.6.44/share/man:/home/builder/.pkgx/lz4.org/v1.10.0/share/man:/home/builder/.pkgx/sourceware.org/bzip2/v1.0.8/man:/home/builder/.pkgx/gnome.org/libxslt/v1.1.42/share/man:/home/builder/.pkgx/ijg.org/v9f/share/man:/home/builder/.pkgx/gnu.org/libiconv/v1.17.0/share/man:/home/builder/.pkgx/kerberos.org/v1.21.3/share/man:/home/builder/.pkgx/gnu.org/autoconf/v2.72.0/share/man:/home/builder/.pkgx/thrysoee.dk/editline/v3.1.0/share/man:/home/builder/.pkgx/bcrypt.sourceforge.net/v1.1.0/man:/home/builder/.pkgx/re2c.org/v3.1.0/share/man:/home/builder/.pkgx/php.net/v8.3.11/share/man:/home/builder/.pkgx/google.com/webp/v1.4.0/share/man:${MANPATH}:/usr/share/man"
PATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/facebook.com/zstd/v1.5.6/bin:/home/builder/.pkgx/pcre.org/v2/v10.44.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/sqlite.org/v3.46.1/bin:/home/builder/.pkgx/curl.se/v8.10.0/bin:/home/builder/.pkgx/gnu.org/m4/v1.4.19/bin:/home/builder/.pkgx/perl.org/v5.40.0/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/tukaani.org/xz/v5.6.2/bin:/home/builder/.pkgx/simplesystems.org/libtiff/v4.6.0/bin:/home/builder/.pkgx/libjpeg-turbo.org/v2.1.5.1/bin:/home/builder/.pkgx/gnu.org/readline/v8.2.13/bin:/home/builder/.pkgx/gnu.org/sed/v4.9.0/bin:/home/builder/.pkgx/gnu.org/bison/v3.8.2/bin:/home/builder/.pkgx/gnome.org/libxml2/v2.11.9/bin:/home/builder/.pkgx/invisible-island.net/ncurses/v6.4.0/bin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/giflib.sourceforge.io/v5.2.2/bin:/home/builder/.pkgx/gnu.org/gettext/v0.22.5/bin:/home/builder/.pkgx/libpng.org/v1.6.44/bin:/home/builder/.pkgx/lz4.org/v1.10.0/bin:/home/builder/.pkgx/sourceware.org/bzip2/v1.0.8/bin:/home/builder/.pkgx/libzip.org/v1.9.2/bin:/home/builder/.pkgx/gnome.org/libxslt/v1.1.42/bin:/home/builder/.pkgx/ijg.org/v9f/bin:/home/builder/.pkgx/gnu.org/libiconv/v1.17.0/bin:/home/builder/.pkgx/apache.org/apr-util/v1.6.3/bin:/home/builder/.pkgx/kerberos.org/v1.21.3/bin:/home/builder/.pkgx/kerberos.org/v1.21.3/sbin:/home/builder/.pkgx/gnu.org/autoconf/v2.72.0/bin:/home/builder/.pkgx/apache.org/apr/v1.7.5/bin:/home/builder/.pkgx/bcrypt.sourceforge.net/v1.1.0/bin:/home/builder/.pkgx/re2c.org/v3.1.0/bin:/home/builder/.pkgx/php.net/v8.3.11/bin:/home/builder/.pkgx/php.net/v8.3.11/sbin:/home/builder/.pkgx/github.com/kkos/oniguruma/v6.9.9/bin:/home/builder/.pkgx/google.com/webp/v1.4.0/bin${PATH:+:$PATH}"
LD_LIBRARY_PATH="/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/facebook.com/zstd/v1.5.6/lib:/home/builder/.pkgx/pcre.org/v2/v10.44.0/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/sqlite.org/v3.46.1/lib:/home/builder/.pkgx/curl.se/v8.10.0/lib:/home/builder/.pkgx/perl.org/v5.40.0/lib:/home/builder/.pkgx/sourceware.org/libffi/v3.4.6/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/tukaani.org/xz/v5.6.2/lib:/home/builder/.pkgx/simplesystems.org/libtiff/v4.6.0/lib:/home/builder/.pkgx/libjpeg-turbo.org/v2.1.5.1/lib:/home/builder/.pkgx/gnu.org/readline/v8.2.13/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/libsodium.org/v1.0.18/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/bison/v3.8.2/lib:/home/builder/.pkgx/gnome.org/libxml2/v2.11.9/lib:/home/builder/.pkgx/invisible-island.net/ncurses/v6.4.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/giflib.sourceforge.io/v5.2.2/lib:/home/builder/.pkgx/gnu.org/gettext/v0.22.5/lib:/home/builder/.pkgx/libpng.org/v1.6.44/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/libstdcxx/v14.2.0/lib:/home/builder/.pkgx/lz4.org/v1.10.0/lib:/home/builder/.pkgx/sourceware.org/bzip2/v1.0.8/lib:/home/builder/.pkgx/libzip.org/v1.9.2/lib:/home/builder/.pkgx/gnome.org/libxslt/v1.1.42/lib:/home/builder/.pkgx/ijg.org/v9f/lib:/home/builder/.pkgx/gnu.org/libiconv/v1.17.0/lib:/home/builder/.pkgx/apache.org/apr-util/v1.6.3/lib:/home/builder/.pkgx/kerberos.org/v1.21.3/lib:/home/builder/.pkgx/thrysoee.dk/editline/v3.1.0/lib:/home/builder/.pkgx/apache.org/apr/v1.7.5/lib:/home/builder/.pkgx/php.net/v8.3.11/lib:/home/builder/.pkgx/github.com/kkos/oniguruma/v6.9.9/lib:/home/builder/.pkgx/google.com/webp/v1.4.0/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" |
probably an ok move |
Seems to contain |
yup, and even reverting to 1.1.6 doesn't solve it: https://github.com/pkgxdev/pantry/actions/runs/10891688927/job/30223144500 something strange up with x86-64. maybe the lib isn't in the right place. |
nah, couldn't be that easy: pkgx/work $ ls ~/.pkgx/gnu.org/gcc/libstdcxx/v14.2.0/lib/
gcc libstdc++.so libstdc++exp.la
libgcc_s.so libstdc++.so.6 libstdc++fs.a
libgcc_s.so.1 libstdc++.so.6.0.33 libstdc++fs.la
libstdc++.a libstdc++.so.6.0.33-gdb.py libsupc++.a
libstdc++.la libstdc++exp.a libsupc++.la |
|
very mysterious. |
closes #1036