Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2-rc #1031

Merged
merged 1 commit into from
Sep 6, 2024
Merged

v1.2-rc #1031

merged 1 commit into from
Sep 6, 2024

Conversation

mxcl
Copy link
Member

@mxcl mxcl commented Sep 6, 2024

No description provided.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 6, 2024
@coveralls
Copy link

coveralls commented Sep 6, 2024

Pull Request Test Coverage Report for Build 10740381173

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.724%

Totals Coverage Status
Change from base Build 10740366152: 0.02%
Covered Lines: 1486
Relevant Lines: 1603

💛 - Coveralls

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 6, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 6, 2024
@felipecrs
Copy link
Contributor

@mxcl mxcl merged commit e0a79cb into main Sep 6, 2024
16 checks passed
@mxcl mxcl deleted the v1.2-rc branch September 6, 2024 14:45
@mxcl
Copy link
Member Author

mxcl commented Sep 6, 2024

deploy failure, any clue jacob? https://github.com/pkgxdev/pkgx/actions/runs/10740478635/job/29788773039#step:6:35

Supporting linux aarch64 was probs another dumb call on my part.

@jhheider
Copy link
Contributor

jhheider commented Sep 6, 2024

I know exactly what this is:

https://github.com/pkgxdev/pantry/blob/82eae785a33cc58a954d9f29d34966589026a631/projects/deno.land/package.yml#L16-L22

https://github.com/pkgxdev/pantry/blob/82eae785a33cc58a954d9f29d34966589026a631/projects/deno.land/package.yml#L102-L109

https://github.com/pkgxdev/pantry/blob/82eae785a33cc58a954d9f29d34966589026a631/projects/pkgx.sh/package.yml#L21-L24

basically in... 1.43ish?... they started downloading the embeddable runtime when running deno compile, but when they added linux/aarch64, they used ubuntu20, iirc. so their glibc is far too new. ours builds with the correct glibc, ships alongside the regular binary, and can be selected explicitly (as we do for pantry) for linux/aarch64.

@felipecrs
Copy link
Contributor

felipecrs commented Sep 6, 2024

I think it would be reasonable if deno itself compiled their denort binaries against an older version of glibc for better compatibility. I guess it would be good to them too... except that the binary size would increase a little.

@jhheider
Copy link
Contributor

jhheider commented Sep 6, 2024

if i recall from the PR when they introduced, they ported in an external community contribution because they weren't (really) supporting linux/aarch64 as a first-class target internally. so they just captured his work and considered that sufficient for most use cases (which it probably is for now). glibc targets are, frankly, the absolute worst.

@mxcl
Copy link
Member Author

mxcl commented Sep 6, 2024

But this is the pkgx node failing?

node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.31' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by node)

The pkgxdev/dev GitHub Action is using pkgx to run node.

@jhheider
Copy link
Contributor

jhheider commented Sep 6, 2024

that is very strange; that should be the exact same system it was built on. it's looking for libstdc++, so maybe we introduced a dependency that we're not satisfying :(

@jhheider
Copy link
Contributor

jhheider commented Sep 6, 2024

i bet the problem is that libstdcxx is its own package now; though gcc should still have it. i'll update and see if that fixes it.

https://github.com/pkgxdev/pantry/blob/82eae785a33cc58a954d9f29d34966589026a631/projects/nodejs.org/package.yml#L16

jhheider added a commit to pkgxdev/pantry that referenced this pull request Sep 6, 2024
@jhheider jhheider mentioned this pull request Sep 6, 2024
@mxcl
Copy link
Member Author

mxcl commented Sep 7, 2024

@mxcl
Copy link
Member Author

mxcl commented Sep 7, 2024

it is frustrating that these things are not detectable until people like ourselves try to do things like these. That needs fixing for sure. The package graph should not be so fragile.

jhheider added a commit to pkgxdev/pantry that referenced this pull request Sep 7, 2024
jhheider added a commit to pkgxdev/pantry that referenced this pull request Sep 7, 2024
jhheider added a commit to pkgxdev/pantry that referenced this pull request Sep 7, 2024
@jhheider
Copy link
Contributor

jhheider commented Sep 7, 2024

Oddly, the command runs fine on both runners:

builder@67d2b025043c:/$ /bin/bash --noprofile --norc -e -o pipefail -c 'pkgx +node node --version'~/.pkgx/gnu.org/mpc/v1.3.1
 ✓  ~/.pkgx/curl.se/ca-certs/v2024.7.2
 ✓  ~/.pkgx/gnu.org/gmp/v6.3.0
 ✓  ~/.pkgx/gnu.org/mpfr/v4.2.1
 ✓  ~/.pkgx/npmjs.com/v10.8.3
 ✓  ~/.pkgx/openssl.org/v1.1.1w
 ✓  ~/.pkgx/unicode.org/v71.1.0
 ✓  ~/.pkgx/nodejs.org/v22.8.0
 ✓  ~/.pkgx/gnu.org/binutils/v2.43.1
 ✓  ~/.pkgx/gnu.org/gcc/v14.2.0
v22.8.0

sooooo, something is up.

@jhheider
Copy link
Contributor

jhheider commented Sep 7, 2024

but this doesn't:

builder@67d2b025043c:/$   if ! node --version >/dev/null 2>&1; then
>     eval "$(pkgx +node)"
>   fi
builder@67d2b025043c:/$   node --version
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.31' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by node)

@mxcl
Copy link
Member Author

mxcl commented Sep 7, 2024

I pushed it through by using denoland/setup-deno to install deno instead of using pkgxdev/dev

@jhheider
Copy link
Contributor

jhheider commented Sep 7, 2024

it's because eval "$(pkgx +node)" isn't adding LD_LIBRARY_PATH to the env. neither does source <(pkgx +node). so, strange behavior from bash:

builder@67d2b025043c:/$ env
HOSTNAME=67d2b025043c
PWD=/
HOME=/home/builder
LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arc=01;31:*.arj=01;31:*.taz=01;31:*.lha=01;31:*.lz4=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.tzo=01;31:*.t7z=01;31:*.zip=01;31:*.z=01;31:*.dz=01;31:*.gz=01;31:*.lrz=01;31:*.lz=01;31:*.lzo=01;31:*.xz=01;31:*.zst=01;31:*.tzst=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.alz=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.cab=01;31:*.wim=01;31:*.swm=01;31:*.dwm=01;31:*.esd=01;31:*.jpg=01;35:*.jpeg=01;35:*.mjpg=01;35:*.mjpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.m4a=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.oga=00;36:*.opus=00;36:*.spx=00;36:*.xspf=00;36:
TERM=xterm
SHLVL=1
ORGANIZATION=pkgxdev
PATH=/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
_=/usr/bin/env


builder@67d2b025043c:/$ pkgx +node
SSL_CERT_FILE=/home/builder/.pkgx/curl.se/ca-certs/v2024.7.2/ssl/cert.pem
PATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin${PATH:+:$PATH}"
CPATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/include:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/include:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/include:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/include:/home/builder/.pkgx/unicode.org/v71.1.0/include:/home/builder/.pkgx/openssl.org/v1.1.1w/include:/home/builder/.pkgx/zlib.net/v1.3.1/include:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/include:/home/builder/.pkgx/nodejs.org/v22.8.0/include${CPATH:+:$CPATH}"
LIBRARY_PATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/nodejs.org/v22.8.0/lib:/home/builder/.pkgx/npmjs.com/v10.8.3/lib${LIBRARY_PATH:+:$LIBRARY_PATH}"
XDG_DATA_DIRS="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/share:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/share:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/share:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/share:/home/builder/.pkgx/unicode.org/v71.1.0/share:/home/builder/.pkgx/zlib.net/v1.3.1/share:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/share:/home/builder/.pkgx/nodejs.org/v22.8.0/share${XDG_DATA_DIRS:+:$XDG_DATA_DIRS}"
MANPATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/share/man:/home/builder/.pkgx/unicode.org/v71.1.0/share/man:/home/builder/.pkgx/zlib.net/v1.3.1/share/man:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/share/man:/home/builder/.pkgx/nodejs.org/v22.8.0/share/man:${MANPATH}:/usr/share/man"
PKG_CONFIG_PATH="/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib/pkgconfig:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib/pkgconfig:/home/builder/.pkgx/unicode.org/v71.1.0/lib/pkgconfig:/home/builder/.pkgx/openssl.org/v1.1.1w/lib/pkgconfig:/home/builder/.pkgx/zlib.net/v1.3.1/lib/pkgconfig${PKG_CONFIG_PATH:+:$PKG_CONFIG_PATH}"
LD_LIBRARY_PATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/nodejs.org/v22.8.0/lib:/home/builder/.pkgx/npmjs.com/v10.8.3/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"


builder@67d2b025043c:/$ eval "$(pkgx +node)"


builder@67d2b025043c:/$ env
HOSTNAME=67d2b025043c
PWD=/
HOME=/home/builder
LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arc=01;31:*.arj=01;31:*.taz=01;31:*.lha=01;31:*.lz4=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.tzo=01;31:*.t7z=01;31:*.zip=01;31:*.z=01;31:*.dz=01;31:*.gz=01;31:*.lrz=01;31:*.lz=01;31:*.lzo=01;31:*.xz=01;31:*.zst=01;31:*.tzst=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.alz=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.cab=01;31:*.wim=01;31:*.swm=01;31:*.dwm=01;31:*.esd=01;31:*.jpg=01;35:*.jpeg=01;35:*.mjpg=01;35:*.mjpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.m4a=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.oga=00;36:*.opus=00;36:*.spx=00;36:*.xspf=00;36:
TERM=xterm
SHLVL=1
ORGANIZATION=pkgxdev
PATH=/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

@jhheider
Copy link
Contributor

jhheider commented Sep 7, 2024

hm, actually LD_LIBRARY_PATH is getting set (env just doesn't show it), and it has the right path. but the shell isn't using its libstdc++.so:

/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/nodejs.org/v22.8.0/lib:/home/builder/.pkgx/npmjs.com/v10.8.3/lib:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/nodejs.org/v22.8.0/lib:/home/builder/.pkgx/npmjs.com/v10.8.3/lib:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/nodejs.org/v22.8.0/lib:/home/builder/.pkgx/npmjs.com/v10.8.3/lib:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/nodejs.org/v22.8.0/lib:/home/builder/.pkgx/npmjs.com/v10.8.3/lib

@mxcl
Copy link
Member Author

mxcl commented Sep 7, 2024

good sleuthing and another wtf for our approach. I wonder what is happening.

@jhheider
Copy link
Contributor

jhheider commented Sep 7, 2024

so, pkgx node --version works, but eval "$(pkgx +node)" && node --version doesn't.

builder@67d2b025043c:/$ pkgx node --version
v22.8.0
builder@67d2b025043c:/$ eval "$(pkgx +node)" && node --version
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.31' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by node)```

@jhheider
Copy link
Contributor

jhheider commented Sep 7, 2024

you'd think LD_LIBRARY_PATH would make everything easier, but the GLIBC/GLIBCXX makes it all harder again.

@mxcl
Copy link
Member Author

mxcl commented Sep 7, 2024

interesting af

@jhheider
Copy link
Contributor

jhheider commented Sep 7, 2024

1.2 speeds up ./configure-based builds by... 5x?

1.2: https://github.com/pkgxdev/pantry/actions/runs/10753823241 (linux: 1.5 min)
1.1.6: https://github.com/pkgxdev/pantry/actions/runs/10750023515 (linux: 7.5 min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants