-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.2-rc #1031
Conversation
Pull Request Test Coverage Report for Build 10740381173Details
💛 - Coveralls |
@mxcl, please consider the following simple fixes for this release: |
deploy failure, any clue jacob? https://github.com/pkgxdev/pkgx/actions/runs/10740478635/job/29788773039#step:6:35 Supporting linux aarch64 was probs another dumb call on my part. |
I know exactly what this is: basically in... 1.43ish?... they started downloading the embeddable runtime when running |
I think it would be reasonable if deno itself compiled their denort binaries against an older version of glibc for better compatibility. I guess it would be good to them too... except that the binary size would increase a little. |
if i recall from the PR when they introduced, they ported in an external community contribution because they weren't (really) supporting linux/aarch64 as a first-class target internally. so they just captured his work and considered that sufficient for most use cases (which it probably is for now). glibc targets are, frankly, the absolute worst. |
But this is the pkgx
The pkgxdev/dev GitHub Action is using pkgx to run node. |
that is very strange; that should be the exact same system it was built on. it's looking for libstdc++, so maybe we introduced a dependency that we're not satisfying :( |
i bet the problem is that libstdcxx is its own package now; though gcc should still have it. i'll update and see if that fixes it. |
it is frustrating that these things are not detectable until people like ourselves try to do things like these. That needs fixing for sure. The package graph should not be so fragile. |
Oddly, the command runs fine on both runners: builder@67d2b025043c:/$ /bin/bash --noprofile --norc -e -o pipefail -c 'pkgx +node node --version'
✓ ~/.pkgx/gnu.org/mpc/v1.3.1
✓ ~/.pkgx/curl.se/ca-certs/v2024.7.2
✓ ~/.pkgx/gnu.org/gmp/v6.3.0
✓ ~/.pkgx/gnu.org/mpfr/v4.2.1
✓ ~/.pkgx/npmjs.com/v10.8.3
✓ ~/.pkgx/openssl.org/v1.1.1w
✓ ~/.pkgx/unicode.org/v71.1.0
✓ ~/.pkgx/nodejs.org/v22.8.0
✓ ~/.pkgx/gnu.org/binutils/v2.43.1
✓ ~/.pkgx/gnu.org/gcc/v14.2.0
v22.8.0 sooooo, something is up. |
but this doesn't: builder@67d2b025043c:/$ if ! node --version >/dev/null 2>&1; then
> eval "$(pkgx +node)"
> fi
builder@67d2b025043c:/$ node --version
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.31' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by node) |
I pushed it through by using |
it's because builder@67d2b025043c:/$ env
HOSTNAME=67d2b025043c
PWD=/
HOME=/home/builder
LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arc=01;31:*.arj=01;31:*.taz=01;31:*.lha=01;31:*.lz4=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.tzo=01;31:*.t7z=01;31:*.zip=01;31:*.z=01;31:*.dz=01;31:*.gz=01;31:*.lrz=01;31:*.lz=01;31:*.lzo=01;31:*.xz=01;31:*.zst=01;31:*.tzst=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.alz=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.cab=01;31:*.wim=01;31:*.swm=01;31:*.dwm=01;31:*.esd=01;31:*.jpg=01;35:*.jpeg=01;35:*.mjpg=01;35:*.mjpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.m4a=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.oga=00;36:*.opus=00;36:*.spx=00;36:*.xspf=00;36:
TERM=xterm
SHLVL=1
ORGANIZATION=pkgxdev
PATH=/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
_=/usr/bin/env
builder@67d2b025043c:/$ pkgx +node
SSL_CERT_FILE=/home/builder/.pkgx/curl.se/ca-certs/v2024.7.2/ssl/cert.pem
PATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin${PATH:+:$PATH}"
CPATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/include:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/include:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/include:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/include:/home/builder/.pkgx/unicode.org/v71.1.0/include:/home/builder/.pkgx/openssl.org/v1.1.1w/include:/home/builder/.pkgx/zlib.net/v1.3.1/include:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/include:/home/builder/.pkgx/nodejs.org/v22.8.0/include${CPATH:+:$CPATH}"
LIBRARY_PATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/nodejs.org/v22.8.0/lib:/home/builder/.pkgx/npmjs.com/v10.8.3/lib${LIBRARY_PATH:+:$LIBRARY_PATH}"
XDG_DATA_DIRS="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/share:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/share:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/share:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/share:/home/builder/.pkgx/unicode.org/v71.1.0/share:/home/builder/.pkgx/zlib.net/v1.3.1/share:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/share:/home/builder/.pkgx/nodejs.org/v22.8.0/share${XDG_DATA_DIRS:+:$XDG_DATA_DIRS}"
MANPATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/share/man:/home/builder/.pkgx/unicode.org/v71.1.0/share/man:/home/builder/.pkgx/zlib.net/v1.3.1/share/man:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/share/man:/home/builder/.pkgx/nodejs.org/v22.8.0/share/man:${MANPATH}:/usr/share/man"
PKG_CONFIG_PATH="/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib/pkgconfig:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib/pkgconfig:/home/builder/.pkgx/unicode.org/v71.1.0/lib/pkgconfig:/home/builder/.pkgx/openssl.org/v1.1.1w/lib/pkgconfig:/home/builder/.pkgx/zlib.net/v1.3.1/lib/pkgconfig${PKG_CONFIG_PATH:+:$PKG_CONFIG_PATH}"
LD_LIBRARY_PATH="/home/builder/.pkgx/gnu.org/binutils/v2.43.1/lib:/home/builder/.pkgx/gnu.org/gmp/v6.3.0/lib:/home/builder/.pkgx/gnu.org/mpfr/v4.2.1/lib:/home/builder/.pkgx/gnu.org/mpc/v1.3.1/lib:/home/builder/.pkgx/unicode.org/v71.1.0/lib:/home/builder/.pkgx/openssl.org/v1.1.1w/lib:/home/builder/.pkgx/zlib.net/v1.3.1/lib:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/lib:/home/builder/.pkgx/nodejs.org/v22.8.0/lib:/home/builder/.pkgx/npmjs.com/v10.8.3/lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"
builder@67d2b025043c:/$ eval "$(pkgx +node)"
builder@67d2b025043c:/$ env
HOSTNAME=67d2b025043c
PWD=/
HOME=/home/builder
LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arc=01;31:*.arj=01;31:*.taz=01;31:*.lha=01;31:*.lz4=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.tzo=01;31:*.t7z=01;31:*.zip=01;31:*.z=01;31:*.dz=01;31:*.gz=01;31:*.lrz=01;31:*.lz=01;31:*.lzo=01;31:*.xz=01;31:*.zst=01;31:*.tzst=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.alz=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.cab=01;31:*.wim=01;31:*.swm=01;31:*.dwm=01;31:*.esd=01;31:*.jpg=01;35:*.jpeg=01;35:*.mjpg=01;35:*.mjpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.m4a=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.oga=00;36:*.opus=00;36:*.spx=00;36:*.xspf=00;36:
TERM=xterm
SHLVL=1
ORGANIZATION=pkgxdev
PATH=/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/home/builder/.pkgx/gnu.org/binutils/v2.43.1/bin:/home/builder/.pkgx/unicode.org/v71.1.0/bin:/home/builder/.pkgx/unicode.org/v71.1.0/sbin:/home/builder/.pkgx/openssl.org/v1.1.1w/bin:/home/builder/.pkgx/gnu.org/gcc/v14.2.0/bin:/home/builder/.pkgx/nodejs.org/v22.8.0/bin:/home/builder/.pkgx/npmjs.com/v10.8.3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin |
hm, actually LD_LIBRARY_PATH is getting set (env just doesn't show it), and it has the right path. but the shell isn't using its libstdc++.so:
|
good sleuthing and another wtf for our approach. I wonder what is happening. |
so, builder@67d2b025043c:/$ pkgx node --version
v22.8.0
builder@67d2b025043c:/$ eval "$(pkgx +node)" && node --version
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.31' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by node)
node: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by node)``` |
you'd think LD_LIBRARY_PATH would make everything easier, but the GLIBC/GLIBCXX makes it all harder again. |
interesting af |
1.2 speeds up 1.2: https://github.com/pkgxdev/pantry/actions/runs/10753823241 (linux: 1.5 min) |
No description provided.