SIP transport: call callback when data is dropped due to invalid headers #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanangizz
reviewed
Aug 1, 2024
| /* Not enough data in packet. */ | ||
| return total_processed; | ||
| } | ||
| dd_status = PJSIP_ERXOVERFLOW; |
There was a problem hiding this comment.
- Better put comment for future ref about the two cases of
EPARTIALMSG, i.e: really partial message or overflow (buffer too small or packet too large)? - And/or print log (as in the other errors)?
nanangizz
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To continue #3961.
Currently, the app is not notified if incoming data is dropped due to errors of
PJSIP_EMISSINGHDRorPJSIP_EINVALIDHDR. So the patch will now call the callbacks in such scenario.The original patch is created by @pespin.
This PR is to minimise the flow/code changes.