Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gres handling for teach #259

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Adding gres handling for teach #259

merged 1 commit into from
Aug 23, 2024

Conversation

yassinkhalifa
Copy link
Contributor

Adding srun's gres parameter handling logic for teach in order to pass the requested gres and set the default num_gpus if not requested when c=teach and p=gpu

Adding srun's gres parameter handling logic for teach in order to pass the requested gres and set the default num_gpus if not requested when c=teach and p=gpu
@yassinkhalifa yassinkhalifa linked an issue Aug 23, 2024 that may be closed by this pull request
Copy link
Contributor

@chnixi chnixi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still doesn't seem to work, same issue as before:

[chx33@login0 ~]$ crc-interactive -e -p gpu
[chx33@teach-gpu-n0 ~]$ nvidia-smi
No devices were found

@yassinkhalifa
Copy link
Contributor Author

@chnixi This hasn't been installed to the cluster yet Chen. I'll let you know once this is done.

@chnixi chnixi merged commit f7f3f28 into main Aug 23, 2024
11 checks passed
@chnixi chnixi deleted the crc-interactive-teach branch August 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crc-interactive does not work on teach gpu
2 participants