-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-stage docker build #122
Conversation
Co-authored-by: Daniel Perrefort <[email protected]>
… to match rpm.spec version syntax
github actions files need to be updated, but wanted to get any feedback from testing locally first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to the docker file look good. Doesn't the entrypoint script need updating to launch the rest API daemon? I tried running the slurmrestd
command from within the container but I get the following error:
slurmrestd: fatal: Unable to unshare System V namespace: Operation not permitted
Yeah, the entrypoint script needs to be updated, as well as the |
SGTM. Merge at will. |
This PR is for a multi-stage docker build of the slurm test environment. This will allow us to remove the static RPMs from git and build them as new slurm versions are added to the test list. The first stage installs the required
devel
packages for all possible plugins then builds the slurm RPMs. The second stage copies in the slurm RPMs from the first stage and installs them.20.02.5
. As slurm versions are removed from the download archive, they should be dropped from testing22.05.11
, the version currently running on the clusterslurmrestd
package by defaultTested locally using;
podman build -t slurm-test-env:22.05.11 -f Dockerfile --build-arg SLURM_VERSION=22.05.11
podman run -it --rm -v ./tests/:/tests localhost/slurm-test-env:22.05.11 bats /tests