Skip to content

Commit

Permalink
Grid spacing: css nits, remove unused variable, string case fix
Browse files Browse the repository at this point in the history
  • Loading branch information
juliandescottes committed Feb 18, 2018
1 parent 3e450c3 commit 7797616
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 5 deletions.
28 changes: 26 additions & 2 deletions src/css/settings-application.css
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,35 @@
flex-shrink: 0;
}

.settings-item-grid-size .size-picker-option {
.grid-spacing-container .size-picker-option[data-size='1'] {
padding: 7px;
}
.grid-spacing-container .size-picker-option[data-size='2'] {
padding: 6px;
}
.grid-spacing-container .size-picker-option[data-size='4'] {
padding: 5px;
}
.grid-spacing-container .size-picker-option[data-size='8'] {
padding: 4px;
}
.grid-spacing-container .size-picker-option[data-size='16'] {
padding: 3px;
}
.grid-spacing-container .size-picker-option[data-size='32'] {
padding: 2px;
}
.grid-spacing-container .size-picker-option[data-size='64'] {
padding: 1px;
}

.settings-item-grid-size .size-picker-option,
.settings-item-grid-spacing .size-picker-option {
border-color: #888;
}

.settings-item-grid-size .size-picker-option:not(.selected):hover {
.settings-item-grid-size .size-picker-option:not(.selected):hover,
.settings-item-grid-spacing .size-picker-option:not(.selected):hover {
border-color: white;
}

Expand Down
1 change: 0 additions & 1 deletion src/js/rendering/frame/FrameRenderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@
displayContext.scale(1 / z, 1 / z);

var drawOrClear;
var drawing = true;
if (gridColor === Constants.TRANSPARENT_COLOR) {
drawOrClear = displayContext.clearRect.bind(displayContext);
} else {
Expand Down
4 changes: 2 additions & 2 deletions src/templates/settings/preferences/grid.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
</div>
</div>
<div class="settings-item settings-item-grid-spacing">
<label>Grid Spacing</label>
<div class="grid-spacing-container spacing-picker-container">
<label>Grid spacing</label>
<div class="grid-spacing-container size-picker-container">
<div class="size-picker-option"
title="1px" rel="tooltip" data-placement="top" data-size="1"></div>
<div class="size-picker-option"
Expand Down

0 comments on commit 7797616

Please sign in to comment.