Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tignes #69

Merged
merged 2 commits into from
Nov 2, 2023
Merged

feat: Tignes #69

merged 2 commits into from
Nov 2, 2023

Conversation

FezVrasta
Copy link
Contributor

There’s a small problem, the website shows the lift status from an iframe, but the iframe domain does not match the Tignes website one. This means the resort URL will point to an unaccessible page.

@pirxpilot
Copy link
Owner

pirxpilot commented Nov 2, 2023

There’s a small problem, the website shows the lift status from an iframe, but the iframe domain does not match the Tignes website one.

You can point url entry to the website and dataUrl entry (same format as url) to the iframe with lift status info. If specified dataUrl is used to get lift status. Sorry - I'll add that info to README

pirxpilot added a commit that referenced this pull request Nov 2, 2023
@FezVrasta
Copy link
Contributor Author

Thanks, I updated it, I also noticed there was an existing parser for lumiplan so I reused it

@FezVrasta
Copy link
Contributor Author

I also fixed the parser as it wasn't applying title case and many resorts put the names all uppercase

@pirxpilot
Copy link
Owner

I also fixed the parser as it wasn't applying title case and many resorts put the names all uppercase

Makes sense. Would be better if I could find some kind of locale aware capitalization lib since Jardin D'enfants is less than ideal. But at least no more shouting on the page ;-)

@pirxpilot pirxpilot merged commit 9b9b906 into pirxpilot:main Nov 2, 2023
1 check passed
@FezVrasta FezVrasta deleted the feat/tignes branch November 2, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants