feat(contract): charge fees on unsetting operator #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xHansLee
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
0xHansLee
commented
Dec 14, 2024
| @@ -21,7 +21,7 @@ gen_binding() { | |||
|
|
|||
| # gen storage layout json | |||
| storage_layout_file=${DIR}/${name_lower}_storage_layout.json | |||
| forge inspect "${contract}" storageLayout > "${storage_layout_file}" | |||
| forge inspect "${contract}" storageLayout --json > "${storage_layout_file}" | |||
There was a problem hiding this comment.
related PR: foundry-rs/foundry#9332
limengformal
approved these changes
Dec 17, 2024
edisonz0718
approved these changes
Dec 17, 2024
0xHansLee
force-pushed
the
hans/charge-fee-unset-operator
branch
from
b93d810 to
d96e676
Compare
Binary uploaded successfully 🎉📦 Version Name: 0.14.1-unstable-528fecd |
limengformal
pushed a commit
that referenced
this pull request
Jan 27, 2025
* chore(*): update execution hash for story (#441) Update execution hash corresponding to this change (piplabs/story-geth#84) issue: none * feat(contract): charge fees on unsetting operator (#439) Charge fees on `unsetOperator` and made changes for CLI to be compatible with this change. issue: #438 * chore(*): update story config (#444) Update story default config issue: none * feat(api): add spendable balance api (#442) add spendable balance API issue: none * feat(genesis): mainnet values in gen alloc and testing (#443) - Unifies Timelock initialization across chains - Refactor admin (if `KEEP_TIMELOCK_ADMIN_ROLE = true`) - Refactor chain ids into utils library - Sets min delay values in mainnet - Test upgrade of last Predeploy proxy and scheduling over min delay issue: none * chore(staking): api and error codes (#445) remove useless api and enhance event processing error codes issue: none --------- Signed-off-by: lutty <[email protected]> Co-authored-by: haodi <[email protected]> Co-authored-by: lutty <[email protected]> --------- Signed-off-by: lutty <[email protected]> Co-authored-by: Ze <[email protected]> Co-authored-by: Rayden Ge <[email protected]> Co-authored-by: Ramarti <[email protected]> Co-authored-by: haodi <[email protected]> Co-authored-by: lutty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charge fees on
unsetOperatorand made changes for CLI to be compatible with this change.issue: #438