fix(*): resolve and close todos #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdubpark
requested review from
LeoHChen,
AndyBoWu,
edisonz0718,
ezreal1997,
limengformal,
0xHansLee and
leeren
as code owners
jdubpark
force-pushed
the
jdub/resolve-todos
branch
from
41497e8 to
6a00fc3
Compare
jdubpark
changed the title
edisonz0718
reviewed
Dec 12, 2024
| @@ -286,7 +252,7 @@ func makeBaseAppOpts(cfg Config) ([]func(*baseapp.BaseApp), error) { | |||
| } | |||
|
|
|||
| return []func(*baseapp.BaseApp){ | |||
| // baseapp.SetOptimisticExecution(), // TODO: Enable this. | |||
There was a problem hiding this comment.
This is an experimental feature and may have impact on things that we don't know. Let's not enable it for now.
There was a problem hiding this comment.
Instead, let's create an issue to track this
There was a problem hiding this comment.
Sure, I got it confused with optimistic building. Disabled in 0498250
0xHansLee
approved these changes
Dec 13, 2024
jdubpark
force-pushed
the
jdub/resolve-todos
branch
from
c0e3cf5 to
0498250
Compare
edisonz0718
approved these changes
Dec 13, 2024
Binary uploaded successfully 🎉📦 Version Name: 0.14.1-unstable-5026d6d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address open TODOs
issue: piplabs/trust-story#19