Include deprecation warnings for LLMUserResponseAggregator and LLMAss… #948
+30
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istantResponseAggregator
|
These are still necessary by LangChain. I need to take a look at it. It's on my list. |
Definitely. Let's keep this open until you have a chance to do that. I wanted to create this because I keep seeing people develop with LLMUserResponseAggregator and LLMAssistantResponseAggregator. |
|
Marking this as draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…istantResponseAggregator
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
The only remaining use of these classes are related to Langchain. We'll clean that up in a separate file.
Note: these classes have been deprecated since October. We need to be more clear about deprecation warnings so developers are aware of the changes.