Avoid cutting off the beginning of the audio #1008
Open
+1,793
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipi87
commented
Jan 16, 2025
| this.botAudio.onplaying = async (event) => { | ||
| this.log("onplaying") | ||
| this.log("Will send the audio message to play the audio at the next tick") | ||
| this.dailyCallObject.sendAppMessage("playable") |
There was a problem hiding this comment.
The "onplaying" event is supposed to trigger only after playback has started (spec here). While it helps, it does not completely solve the issue.
To avoid any audio clipping, if we rely only on this approach, we would still need to add a timeout of at least 1 second before sending the app message.
filipi87
commented
Jan 16, 2025
| return | ||
| await task.queue_frames( | ||
| [ | ||
| SilenceFrame(duration=0.5), |
There was a problem hiding this comment.
To avoid adding a timeout on the client side, we are sending a silence frame before the TTSSpeakFrame. During testing, this approach feels more natural and seems to work better than adding a sleep on the client side.
filipi87
changed the title
filipi87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of signaling using an app message to avoid avoid cutting off the beginning of the audio.