Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing docker images #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pierrediancourt
Copy link

Hey everyone,

This proposal simply uses github actions to build the docker image and push it to dockerhub for arm64 and amd64 architectures when someone push something to master.
I've written this for myself as i wanted to run this project on a Raspberry pi v3 Model B so a docker image for the architecture arm64 was needed and the only official image I found (https://github.com/pinterest/snappass/pkgs/container/snappass%2Fsnappass/versions) wasn't suitable for my arch.
I think having an official build on dockerhub could please any user of this project :)

When merging this, you should create a dockerhub account and a free "read,write,delete" authentication key.
After that you just have to configure the secrets here for things to work
image

I've only followed instructions and examples found here https://github.com/docker/build-push-action
So, of course, there is room for improvement, with, for example a better tagging logic than just having a "latest" version.

Have a nice day

PS: I would fancy having a working build process for armv7 for running on older Rapsberry Pi versions for example. But i'm not planning to work it.
I've seen in the github actions logs when configuring for "linux/arm/v7" that the "cryptography" python library is causing an issue in the build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant