Fixing browser side child log issue (#960) child level can now be set…

… at cr… (#1986) * Fixing browser side child log issue, child level can now be set at creation time, #960 * Added test case for setting child logger level at creation time (#960) --------- Co-authored-by: Steven Li <[email protected]>
pinojs · Jun 11, 2024 · 10bfff4 · 10bfff4
1 parent 8db130e
commit 10bfff4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/browser.js b/browser.js
@@ -195,7 +195,7 @@ function pino (opts) {
     // must happen before the level is assigned
     appendChildLogger(this, newLogger)
     // required to actually initialize the logger functions for any given child
-    newLogger.level = this.level
+    newLogger.level = childOptions.level || this.level // allow level to be set by childOptions
 
     return newLogger
   }

diff --git a/test/browser-child.test.js b/test/browser-child.test.js
@@ -14,6 +14,18 @@ test('child has parent level', ({ end, same, is }) => {
   end()
 })
 
+test('child can set level at creation time', ({ end, same, is }) => {
+  const instance = pino({
+    level: 'error',
+    browser: {}
+  })
+
+  const child = instance.child({}, { level: 'info' }) // first bindings, then options
+
+  same(child.level, 'info')
+  end()
+})
+
 test('changing child level does not affect parent', ({ end, same, is }) => {
   const instance = pino({
     level: 'error',