-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: Update supported OS versions #2476
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6a16c5e
to
21ec16b
Compare
case "centos": | ||
// CentOS Linux is EOL | ||
// CentOS Stream 9 and newer is still fine | ||
if ver, _ := strconv.ParseFloat(osInfo.Version, 64); ver < 9 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a little newer to me, maybe 7.3
or so? Or mark result.warn
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You think we should still list CentOS Linux 7.3 as supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You think we should still list CentOS Linux 7.3 as supported?
I just worry existed tiup deployed on CentOS7
will error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CentOS Linux 7.3 and CentOS Stream 8 don't have upstream support anymore as they are EOL.
TiDB will end support for CentOS 7 in v8.5.
This is just a check and it won't prevent deployment.
I'm ok with listing 7.x as supported for now and then add a warning about deprecation.
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
tiup cluster check ...
might report different information than https://docs.pingcap.com/tidb/stable/hardware-and-software-requirements#os-and-platform-requirementsWhat is changed and how it works?
Check List
Tests
Release notes: