Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include MySQL 9.x in versions that don't need --comments #2469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include MySQL 9.x in versions that don't need --comments #2469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion components/playground/playground.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1512,7 +1512,12 @@ func mysqlCommand() (cmd string) {
}
vMaj, vMin, _, err := parseMysqlVersion(string(mysqlVerOutput))
if err == nil {
if vMaj == 8 && vMin >= 1 { // 8.1.0 and newer
// MySQL Client 8.1.0 and newer
if vMaj == 8 && vMin >= 1 {
return "mysql"
}
// MySQL Client 9.x.x. Note that 10.x is likely to be MariaDB, so not using >= here.
if vMaj == 9 {
return "mysql"
}
}
Expand Down
Loading