Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: prompt k8s.io/api version #11866

Merged
merged 4 commits into from
Dec 17, 2024
Merged

*: prompt k8s.io/api version #11866

merged 4 commits into from
Dec 17, 2024

Conversation

wlwilliamx
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11865

k8s.io/api has risks of some security issue at current v0.28.x version.

What is changed and how it works?

Prompt the version to v0.29.11.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note 

Prompt k8s.io/api library to 0.29.11 to mitigate possible security risks.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2024
@ti-chi-bot ti-chi-bot bot added the area/dm Issues or PRs related to DM. label Dec 12, 2024
@wlwilliamx
Copy link
Contributor Author

/test verify

@wlwilliamx
Copy link
Contributor Author

/retest

1 similar comment
@wlwilliamx
Copy link
Contributor Author

/retest

@wlwilliamx
Copy link
Contributor Author

/test cdc-integration-mysql-test

@wlwilliamx
Copy link
Contributor Author

/test dm-integration-test

@wlwilliamx
Copy link
Contributor Author

/test cdc-integration-pulsar-test

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2024
@wlwilliamx
Copy link
Contributor Author

/test cdc-integration-pulsar-test

@wlwilliamx
Copy link
Contributor Author

/test cdc-integration-kafka-test

@wlwilliamx wlwilliamx force-pushed the fix/k8s-security-issues-in-br branch from 62c6656 to 75691e2 Compare December 13, 2024 14:32
@wlwilliamx
Copy link
Contributor Author

/test verify

@wlwilliamx
Copy link
Contributor Author

/test engine-integration-test

@wlwilliamx
Copy link
Contributor Author

/retest

@wlwilliamx
Copy link
Contributor Author

/test cdc-integration-pulsar-test

@wlwilliamx
Copy link
Contributor Author

/test cdc-integration-kafka-test

@wlwilliamx
Copy link
Contributor Author

/test cdc-integration-pulsar-test

@wlwilliamx
Copy link
Contributor Author

/test cdc-integration-mysql-test

@wlwilliamx wlwilliamx force-pushed the fix/k8s-security-issues-in-br branch from 75691e2 to f4b8b0c Compare December 16, 2024 11:38
@ti-chi-bot ti-chi-bot bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2024
@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 03:33:01.318806724 +0000 UTC m=+927771.407609265: ☑️ agreed by CharlesCheung96.
  • 2024-12-17 03:51:14.829491477 +0000 UTC m=+928864.918294021: ☑️ agreed by D3Hunter.

@wlwilliamx
Copy link
Contributor Author

/retest

3 similar comments
@wlwilliamx
Copy link
Contributor Author

/retest

@wlwilliamx
Copy link
Contributor Author

/retest

@wlwilliamx
Copy link
Contributor Author

/retest

@wlwilliamx
Copy link
Contributor Author

/test cdc-integration-storage-test

@ti-chi-bot ti-chi-bot bot merged commit 690b2a9 into pingcap:master Dec 17, 2024
17 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 17, 2024
@wlwilliamx @ti-chi-bot
This is an automated cherry-pick of pingcap#11866
a1bbf63 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11898.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 17, 2024
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11899.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 17, 2024
@wlwilliamx @ti-chi-bot
This is an automated cherry-pick of pingcap#11866
7b11d2f 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 17, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11900.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 17, 2024
@wlwilliamx @ti-chi-bot
This is an automated cherry-pick of pingcap#11866
2434932 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 17, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 17, 2024
@wlwilliamx @ti-chi-bot
This is an automated cherry-pick of pingcap#11866
467c341 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #11901.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 17, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 17, 2024
@wlwilliamx @ti-chi-bot
This is an automated cherry-pick of pingcap#11866
4d33ba7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11902.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 17, 2024
Open
ti-chi-bot bot pushed a commit that referenced this pull request Dec 18, 2024
@ti-chi-bot
*: prompt k8s.io/api version (#11866) (#11899)
9f0a11c 
close #11865
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2024

@wlwilliamx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-kafka-test f4b8b0c link true /test cdc-integration-kafka-test
pull-dm-integration-test 72e2b7d link true /test dm-integration-test
pull-cdc-integration-storage-test f4b8b0c link true /test cdc-integration-storage-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Dec 19, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2024
@ti-chi-bot
*: prompt k8s.io/api version (#11866) (#11900)
cd5e9e4 
close #11865
ti-chi-bot bot pushed a commit that referenced this pull request Jan 6, 2025
@ti-chi-bot
*: prompt k8s.io/api version (#11866) (#11901)
0e6b44f 
close #11865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. area/ticdc Issues or PRs related to TiCDC. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade BR dependency to resolve some security issues
4 participants
@wlwilliamx @ti-chi-bot @D3Hunter @CharlesCheung96