config: Make deprecate-integer-display-length default to true | tidb-test=pr/2414

[dveeden]

What problem does this PR solve?

Issue Number: close #56533 close #17682

Problem Summary:

Change the default for deprecate-integer-display-length.

This affects:

• SHOW CREATE TABLE output
• EXPLAIN output (mostly or only for cast(...) )
• DESCRIBE <table>
• Now a warning occurs if a display width is specified: Warning 1681 Integer display width is deprecated and will be removed in a future release.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Integer display width display has been disabled by default.

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tiprow]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dveeden]

/ok-to-test

[dveeden]

/test all

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.4854%. Comparing base (44f1c14) to head (3593f12).
Report is 1 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56529         +/-   ##
=================================================
- Coverage   73.3610%   56.4854%   -16.8757%     
=================================================
  Files          1634       1759        +125     
  Lines        452548     637478     +184930     
=================================================
+ Hits         331994     360082      +28088     
- Misses       100190     253427     +153237     
- Partials      20364      23969       +3605     

Flag	Coverage Δ
integration	36.6326% <ø> (?)
unit	72.4782% <ø> (-0.0169%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	52.7045% <ø> (+6.6846%)	⬆️

[dveeden]

/test all

[dveeden]

/test all

[dveeden]

/retest

[dveeden]

/test mysql-test

[tiprow]

@dveeden: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dveeden]

/test check_dev

[ti-chi-bot]

@dveeden: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test build
• /test check-dev
• /test check-dev2
• /test mysql-test
• /test pull-br-integration-test
• /test pull-integration-ddl-test
• /test pull-lightning-integration-test
• /test pull-mysql-client-test
• /test unit-test

The following commands are available to trigger optional jobs:

• /test pingcap/tidb/canary_ghpr_unit_test
• /test pull-common-test
• /test pull-e2e-test
• /test pull-integration-common-test
• /test pull-integration-copr-test
• /test pull-integration-jdbc-test
• /test pull-integration-mysql-test
• /test pull-integration-nodejs-test
• /test pull-sqllogic-test
• /test pull-tiflash-test
• /test pull-unit-test-ddlv1

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tidb/ghpr_build
• pingcap/tidb/ghpr_check
• pingcap/tidb/ghpr_check2
• pingcap/tidb/ghpr_mysql_test
• pingcap/tidb/ghpr_unit_test
• pingcap/tidb/pull_integration_ddl_test
• pingcap/tidb/pull_mysql_client_test

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dveeden]

/test check-dev

[tiprow]

@dveeden: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@dveeden: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test fast_test_tiprow_ddlargsv1
• /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

• fast_test_tiprow
• tidb_parser_test

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dveeden]

/retest

[dveeden]

cc @benmeadowcroft @yudongusa

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-10 09:36:14.65650632 +0000 UTC m=+1125130.076719331: ☑️ agreed by Defined2014.
• 2024-10-10 15:09:52.428633404 +0000 UTC m=+1145147.848846415: ☑️ agreed by mjonss.

[bb7133]

LGTM

[yudongusa]

LGTM with document PR (pingcap/docs#19159)

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, CbcWestwolf, Defined2014, mjonss, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CbcWestwolf,Defined2014,bb7133,mjonss]
• pkg/config/OWNERS [yudongusa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dveeden]

/retest

[Defined2014]

Hi @dveeden, please fix the conflict with master branch. Thx