Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update the clients to adopt the latest fix/optimization #53788

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jun 4, 2024

What problem does this PR solve?

Issue Number: ref #35319.

Problem Summary:

What changed and how does it work?

Adopt tikv/client-go#1360.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 4, 2024
Copy link

ti-chi-bot bot commented Jun 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-04 06:19:41.670896901 +0000 UTC m=+3362135.428032487: ☑️ agreed by hi-rustin.
  • 2024-06-04 06:22:03.542349399 +0000 UTC m=+3362277.299484974: ☑️ agreed by rleungx.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.6797%. Comparing base (b23ac8e) to head (dc6795c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53788         +/-   ##
=================================================
- Coverage   74.4310%   55.6797%   -18.7513%     
=================================================
  Files          1506       1646        +140     
  Lines        358004     605486     +247482     
=================================================
+ Hits         266466     337133      +70667     
- Misses        72097     244783     +172686     
- Partials      19441      23570       +4129     
Flag Coverage Δ
integration 22.9194% <0.0000%> (?)
unit 71.4312% <0.0000%> (-1.8619%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 50.4952% <ø> (+6.9761%) ⬆️

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, hi-rustin, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8277203 into pingcap:master Jun 4, 2024
24 checks passed
@JmPotato JmPotato deleted the update_client branch June 4, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants