-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify proto options and do not generate unused fields #1275
Conversation
Signed-off-by: Neil Shen <[email protected]>
* Do not generate XXX_ fields for Go protobuf structs * Enable lite runtime for Rust protobuf files Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
/approve |
What will happen during upgrading if new version add a new filed in the proto, and old version received the new message? @overvenus |
If the old version receives the new message, it will discard new fields unless Both TiDB, PD and their tools are not using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR LGTM, but pay attention that the padding in TiDB need to be removed
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, cfzjywxk, flowbehappy, MyonKeminta, nolouch, overvenus, tiancaiamao, you06, zhangjinpeng87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unify proto options and do not generate unused fields by setting following options.
Tests:
Cc pingcap/tipb#347 a complement PR for tipb.
Close #1278