Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back nullalble = false for DeadlockRequest.entry #1263

Merged

Conversation

MyonKeminta
Copy link
Contributor

Otherwise it would cause deadlock detector in unistore encounter panics.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 4, 2024
Copy link

ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, JmPotato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 04:06:11.105916063 +0000 UTC m=+417295.623968988: ☑️ agreed by JmPotato.
  • 2024-09-04 04:08:53.702829129 +0000 UTC m=+417458.220882056: ☑️ agreed by cfzjywxk.

@MyonKeminta MyonKeminta merged commit 1de8acc into pingcap:master Sep 4, 2024
5 checks passed
@MyonKeminta MyonKeminta deleted the m/add-back-deadlock-entry-not-null branch September 4, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants