Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdpb: support scan regions for range batch #1251

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

you06
Copy link
Contributor

@you06 you06 commented Jun 14, 2024

ref pingcap/tidb#53850

Add an interface which batch scan regions for key ranges.

The test result:

  1. split table into 1000 regions by SPLIT TABLE sbtest1 BETWEEN (0) AND (1000000) REGIONS 1000;
  2. wait until region cache expired.
  3. run a simple query explain analyze select * from sbtest1 limit 1;
  • Without this interface: ...build_task_duration: 81.5ms..., statmenet execution takes 0.11 sec
  • With this interface: ...build_task_duration: 2.7ms..., statement execution takes 0.02 sec

@you06 you06 requested a review from niubell June 14, 2024 09:21
@ti-chi-bot ti-chi-bot bot requested a review from overvenus June 14, 2024 09:21
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jun 14, 2024
@you06 you06 changed the title PD support scan regions for range batch pdpb support scan regions for range batch Jun 17, 2024
@you06 you06 changed the title pdpb support scan regions for range batch pdpb: support scan regions for range batch Jun 17, 2024
Copy link

ti-chi-bot bot commented Jun 18, 2024

@JmPotato: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jun 19, 2024

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp HuSharp requested a review from rleungx June 19, 2024 04:51
@@ -53,6 +53,8 @@ service PD {

rpc ScanRegions(ScanRegionsRequest) returns (ScanRegionsResponse) {}

rpc BatchScanRegions(BatchScanRegionsRequest) returns (BatchScanRegionsResponse) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it replace ScanRegions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think ScanRegions can be deprecated then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then how about adding a comment for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 20, 2024
Copy link

ti-chi-bot bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, HuSharp, JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-20 05:31:23.502113422 +0000 UTC m=+265609.987602239: ☑️ agreed by rleungx.
  • 2024-06-20 06:35:11.867832349 +0000 UTC m=+269438.353321182: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit 118a4ca into pingcap:master Jun 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants