Revert "raft_serverpb: add an extra ExtraMessage::MsgAckCommittedIndex to get committed index. (#1240)"
#1243
Conversation
…ex` to get committed index. (pingcap#1240)" As the committed index can be fetched by the message pair `MsgReadIndex` and `MsgReadIndexResp`, it can be reverted. This reverts commit f87719b.
|
/cc @glorv @SpadeA-Tang |
|
@LykxSassinator: GitHub didn't allow me to request PR reviews from the following users: SpadeA-Tang. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@SpadeA-Tang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: glorv, SpadeA-Tang, you06 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
As the committed index can be fetched by the message pair
MsgReadIndexandMsgReadIndexResp, this newly introduced message pair is redundant, and it can be reverted.This reverts commit f87719b.