Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: add raft applied_index in store heartbeat PeerReport #1235

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Mar 14, 2024

ref tikv/tikv#16717

After tikv/tikv#16626 it is possible that raft applied_index > max(committed_index, persisted). In this case, when do online unsafe recovery, it is better to let the peer has max(applied_index, last_index) become leader so we can recover the maximum amount of data.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glorv glorv merged commit c699538 into pingcap:master Apr 3, 2024
4 checks passed
@glorv glorv deleted the report-aplied-idx branch April 3, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants