Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support s3 config profile #1178

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

takaidohigasi
Copy link
Contributor

@takaidohigasi takaidohigasi commented Sep 4, 2023

add s3 config profile to enhance profile option for br

pingcap/tidb#46609

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2023

CLA assistant check
All committers have signed the CLA.

@takaidohigasi takaidohigasi marked this pull request as ready for review September 4, 2023 02:34
@takaidohigasi takaidohigasi marked this pull request as draft September 4, 2023 02:34
@takaidohigasi takaidohigasi marked this pull request as ready for review September 4, 2023 03:03
@takaidohigasi

This comment was marked as resolved.

@takaidohigasi
Copy link
Contributor Author

mkdir -p /home/runner/work/kvproto/kvproto/bin
/home/runner/work/kvproto/kvproto/scripts/check.sh
diff --git a/scripts/proto.lock b/scripts/proto.lock
index 9fa90a3..5a10b1e 100[6](https://github.com/pingcap/kvproto/actions/runs/6082628871/job/16500801744#step:4:7)44
--- a/scripts/proto.lock
+++ b/scripts/proto.lock
@@ -20150,4 +20150,4 @@
       }
     }
   ]
-}
+}
\ No newline at end of file
Please add proto.lock to git.
make: *** [Makefile:[14](https://github.com/pingcap/kvproto/actions/runs/6082628871/job/16500801744#step:4:15): check] Error 1
Error: Process completed with exit code 2.

@takaidohigasi
Copy link
Contributor Author

@disksing Would you pleaese run the test again?

@disksing disksing merged commit b8ed19b into pingcap:master Sep 14, 2023
3 checks passed
@takaidohigasi takaidohigasi deleted the support-s3-config-profile branch September 15, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants