Add new read response for reject follower read when follower log behind of read index a lot. #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
overvenus
reviewed
Aug 10, 2023
proto/errorpb.proto
Outdated
Comment on lines
166
to
168
| uint64 read_index = 2; | ||
| uint64 apply_index = 3; | ||
| uint64 peer_id = 4; |
There was a problem hiding this comment.
Are they necessary for error handling? How are they used?
There was a problem hiding this comment.
yes, only used for debug, I will change it as reason.
Signed-off-by: bufferflies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tikv pr：tikv/tikv#15270
tikv issue： tikv/tikv#15189