pd: support grpc for min resolved ts #1170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: husharp <[email protected]>
lhy1024
approved these changes
Aug 7, 2023
| message StoreMinResolvedTS { | ||
| uint64 store_id = 1; | ||
| uint64 timestamp = 2; | ||
| } |
JmPotato
reviewed
Aug 7, 2023
|
|
||
| message GetMinResolvedTSRequest { | ||
| RequestHeader header = 1; | ||
| repeated uint64 stores_id = 2; |
There was a problem hiding this comment.
Better add some comments to explain this request and its behavior.
HuSharp
force-pushed
the
support_grpc_get_min_resolved_ts
branch
from
49e0845
to
b6e878a
Compare
Signed-off-by: husharp <[email protected]>
HuSharp
force-pushed
the
support_grpc_get_min_resolved_ts
branch
from
b6e878a
to
34b6745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.