Add skip store limit check for scatter region #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
reviewed
Jul 26, 2023
proto/pdpb.proto
Outdated
| @@ -800,6 +800,7 @@ message ScatterRegionRequest { | |||
| // If regions_id is defined, the region_id would be ignored. | |||
| repeated uint64 regions_id = 6; | |||
| uint64 retry_limit = 7; | |||
| bool skip_limit_check = 8; | |||
There was a problem hiding this comment.
maybe skip_store_limit or skip_store_limit_restriction
limit_check may confuse with retry_limit
There was a problem hiding this comment.
I prefer a more general name but if we don't find one, skip_store_limit is ok to me.
Signed-off-by: Ryan Leung <[email protected]>
3pointer
approved these changes
Jul 27, 2023
nolouch
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref tikv/pd#6593