Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor revision #55

Merged
merged 5 commits into from
Mar 2, 2024
Merged

minor revision #55

merged 5 commits into from
Mar 2, 2024

Conversation

giorez
Copy link
Contributor

@giorez giorez commented Mar 2, 2024

No description provided.

@x1y
Copy link
Collaborator

x1y commented Mar 2, 2024

Please stop reverting changes I made intentionally.

@x1y x1y closed this Mar 2, 2024
@x1y x1y reopened this Mar 2, 2024
@giorez
Copy link
Contributor Author

giorez commented Mar 2, 2024

Please stop reverting changes I made intentionally.

I thought you didn't want ':' before commands, but just simple '.'

Anyway, sorry if I did some mistake in revisioning... just reject the PR.

i just checked ox64 section and there are no ':' before commands block. so there in no concistency in your revisioning approval.

@x1y
Copy link
Collaborator

x1y commented Mar 2, 2024

i just checked ox64 section and there are no ':' before commands block. so there in no concistency in your revisioning approval.

You wrote the Ox64 software pages, it is not great style there either. The commands should not just stand there without context. The context and explanations are provided by the previous paragraph. In some places you try to avoid the explanatory text and then try to conceal it in places where an explanation is required with a " # explanation / comment" at the end of the commands.

Overall this is not ideal, as it doesn't leave space for thoughts, words of warnings or even longer prose. Verbosity in the text is the better solution, as suggested in #57.

@giorez
Copy link
Contributor Author

giorez commented Mar 2, 2024

i see. i'm trying to do my best contributing. since english is not my native language, it a bit hard to increase verbosity. @Pavlos1 helped a lot in writing in very gentle and collaborative manner.

@x1y
Copy link
Collaborator

x1y commented Mar 2, 2024

i see. i'm trying to do my best contributing. since english is not my native language, it a bit hard to increase verbosity. @Pavlos1 helped a lot in writing in very gentle and collaborative manner.

Don't worry

@x1y x1y merged commit bc0e685 into pine64:main Mar 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants