Expose router engine for other implementations #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
force-pushed
the
router-inheritance
branch
2 times, most recently
from
31c381b
to
037d09c
Compare
blakeembrey
added a commit
to blakeembrey/router
that referenced
this pull request
Nov 13, 2015
* Router inheritance (pillarjs#29) * Router exiting (pillarjs#30)
This was referenced Dec 1, 2015
|
@dougwilson Any chance we'll be able to review these sometime? It's been a more than a year (#13) 😮 Otherwise I can look at pulling out the inheritance pieces, I'd love to get a more stable base to continue using (https://www.npmjs.com/package/osprey). |
blakeembrey
force-pushed
the
router-inheritance
branch
from
037d09c
to
8fee2a8
Compare
This was referenced Mar 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #13.
Closes #12.
Implements custom path implementations via router inheritance.
Edit: I also still prefer the simplicity of this PR over #22. If you think about it this way it's cleaner - the router engine is the most basic router which takes a function as the "path matcher". Other implementations can build on this to take strings and regexps, etc. The path accepted for
routeandusecan be though of as the "label" for debugging (and backward compat).