Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove setImmediate support check #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup: remove setImmediate support check #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
unreleased
==================

* Remove `setImmediate` support check
* Remove `Object.setPrototypeOf` polyfill
* Use `Array.flat` instead of `array-flatten` package
* Replace `methods` dependency with standard library
Expand Down
7 changes: 1 addition & 6 deletions lib/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ const slice = Array.prototype.slice
const flatten = Array.prototype.flat
const methods = METHODS.map((method) => method.toLowerCase())

/* istanbul ignore next */
const defer = typeof setImmediate === 'function'
? setImmediate
: function (fn) { process.nextTick(fn.bind.apply(fn, arguments)) }

/**
* Expose `Route`.
*/
Expand Down Expand Up @@ -137,7 +132,7 @@ Route.prototype.dispatch = function dispatch (req, res, done) {

// max sync stack
if (++sync > 100) {
return defer(next, err)
return setImmediate(next, err)
}

let layer
Expand Down
Loading