Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and change default scenarios #89

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Refactor and change default scenarios #89

merged 3 commits into from
Nov 6, 2024
+1,902 −2,682

Commits on Nov 6, 2024

  1. Refactor and change default scenarios 

    Replace SSP2EU with a placeholder, as it no longer a desired scenario, but required in the input preparation pipeline. Remove completely in next release.
Add ADB sources and scenarios (not returned by default yet).
Urban pop share scenarios are improved, so as to never exceed 1, even with bezier extensions.
SSP labour scenarios are now also filled in with UN_popDiv data.
SSP population scenarios now use short term growth rates from PEAP-UN_PopDiv, instead of PEAP-MI, improving the shorterm projections of the smaller countries.
Refactor function arguments that did not comply with lintr rules (fixes pik-piam#13).
Mark "scenario.indicator" naming option as deprecated and remove in next release.
Fix all linter warnings.
Improve scenario documentation and references in vignette (fixes pik-piam#56 and fixes pik-piam#57).
Improve and simplify documentation (fixes pik-piam#16).
Remove "unit" from most functions, assuming instead that the default dollar unit is used throughout the package.
Clean up use of James data set for filling and backwards extension to 1960. These two functions are now cleanly separated from each other. Also, use of the James2019 dataset is dropped (fixes pik-piam#62), due to the fact that there is no reference for this dataset. This does not affect the scenarios much since the dataset is mainly used for its growth rates, and they shouldn't differ to much.
Refactor toolReduce and toolFillWith. toolFillWith now writes to the log which countries are filled in.
Export some of the more useful tool functions.
Speed up bezier extension (fixes pik-piam#78).
Remove MI from future datasets and make it clear that we assume constant extrapolation for most of the MI countries.
Fixes pik-piam#52.
Make choice of graphics device explicit when computing the bezier extensions (fixes pik-piam#79).
Remove || from unit field in calcOutput returns.
    @johanneskoch94
    johanneskoch94 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    78fa871 View commit details
    Browse the repository at this point in the history

  2. Reintroduce changes from pik-piam#96

    @johanneskoch94
    johanneskoch94 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0a61a1a View commit details
    Browse the repository at this point in the history

  3. Bump version

    @johanneskoch94
    johanneskoch94 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    16809dc View commit details
    Browse the repository at this point in the history