Show BusyIndicator in kirigami (refactor _placeholderText) #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmlich
force-pushed
the
placeholderEnabled
branch
from
d33f9d5
to
fd41d47
Compare
jmlich
force-pushed
the
placeholderEnabled
branch
from
fd41d47
to
f9eee88
Compare
jmlich
changed the title
|
Now it seems to be working with Kirigami, Ubuntu Touch and SailfishOS. Steps to reproduce the issue:
The busy indicator should appear and disappear. The position of busy indicator should be sane (upper left corner looks strange). |
jmlich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to make some cleanup of PairingPage. I have found an issue with missing BusyIndicator #406
This pull request intent is to demonstrate what change was done in order to make BusyIndicator visible in pairing page.