forked from bbc/react-transcript-editor
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance no entities spike #13
Closed
Closed
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
d974cfe
commented out auto save and entities-mto reduce some of the convertFr…
e9f62fc
saving progress
77ca865
Merge pull request #12 from pietrop/master
pietrop 422391e
saving progress
bc0018c
remove entitines from stt align
09153fb
saving progress
8bdb216
Added paragraph level highlight
fed4bd2
Saved local storage
4ebda51
clean up
7234a3b
brought back timecodes at speaker level
b0cc657
Removed forced re-render
37dcb1a
generall fixes and clean up
6dec5cb
added FB 5h demo
6e62def
error handling local storage
14d6397
added a 2 hour example + various twwaks
2925925
show timecodes and speaker labels
08a46e5
exporting also save states-mexporting does an align before exporting,…
48294fc
Update packages/components/media-player/index.js
pietrop 2ab3ee5
Update packages/components/media-player/index.js
pietrop e1d7b1d
Update packages/components/media-player/src/PlayerControls/index.js
pietrop be00506
Update packages/components/timed-text-editor/CustomEditor.js
pietrop f5244f5
Update packages/components/timed-text-editor/UpdateTimestamps/index.js
pietrop 56d7477
Update packages/components/transcript-editor/index.js
pietrop 106aee9
Update packages/components/transcript-editor/index.js
pietrop 36688f0
Update packages/components/transcript-editor/index.js
pietrop 2565010
Update packages/components/timed-text-editor/WrapperBlock.module.css
pietrop 467f52b
Update packages/components/timed-text-editor/WrapperBlock.js
pietrop 1835134
Update packages/components/timed-text-editor/WrapperBlock.js
pietrop 76e807b
Merge branch 'performance-no-entities-spike' of github.com:pietrop/re…
e04e408
Renamed getWordsBeforeParagraphBlock
7c94716
requestIdleCallback
8abbaac
handle flag to make auto save optional
77bab6a
Removed unecessary console.log
5ce77c6
fixed css on firefox
8f78ee1
resmoved chat count nonsense
066b777
Removed unecessary console.log
dbfa68a
Refactored and re introduced scroll sync
2d9079c
fixed scrollsync paragraph level
d05876f
fixing Media component in storybook
cf8a9f7
added support for zero seconds
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a minor point, but when selecting a sample video in
demo
before I select thelocal storage
checkbox, the video is automatically loaded and crashes. This might be something you want to uncheck in-code or add aload
button, to allow the user to select all the options before loading the demo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the flow would be, untick
user local storage
then clickload demo
.Coz I have had people using the transcript editor page, in conjunction with autoEdit to correct transcripts, and didn't want to disable the local storage default auto save, just in case they were still using it.
But yeah, it's not ideal UX, probl untick as default would be better for development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah seems sensible to untick by default