Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StrlenFunctionReturnTypeExtension: Cleanup instanceof ConstantString #3780

Open
wants to merge 3 commits into
base: 2.1.x
Choose a base branch
from
Open

StrlenFunctionReturnTypeExtension: Cleanup instanceof ConstantString #3780

wants to merge 3 commits into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jan 11, 2025

No description provided.

@staabm
Copy link
Contributor Author

staabm commented Jan 11, 2025 •
edited
Loading

lets see whether its smarter to resolve it in the heart of the typesystem instead: cleanup after #3781

I looked thru the tests.. we have lots of coverage arround strlen and mb_strlen.

@staabm staabm changed the base branch from 1.12.x to 2.1.x January 11, 2025 15:42
@staabm staabm marked this pull request as ready for review January 11, 2025 15:52
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @phpstan-bot