-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "one-line" comments (starting with //) #202
base: 1.22.x
Are you sure you want to change the base?
Conversation
Hi, thank you, I have a few points that will makes this more complicated.
|
Could you point me to the locations where this should be implemented, then I'll give it a shot. |
Comments need to be added as attributes similarly to how As for Printer, see tests in PrinterTest. Comments should be preserved correctly when printing the same PHPDoc again, and correct comment should be removed when for example removing a key from an array shape. |
@rhertogh do you have any plans to proceed with this PR? I think it's an important feature... 🙏 |
In the event that @rhertogh is MIA, any chance I can prevail upon you to implement this? If you're too busy I can take a crack at it, but I have to confess I couldn't make much sense of the printer tests... |
@shmax Haven't found the time to continue working on this😅. So if you want to take a swing at it please feel free to do so. |
Okay, will do. 👍 |
This PR adds support for comments inside type definitions, e.g.:
Fixes #184