Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints error message when rejecting commit #1108

Merged
merged 9 commits into from
Sep 19, 2023
Merged

Prints error message when rejecting commit #1108

merged 9 commits into from
Sep 19, 2023

Conversation

EwenQuim
Copy link
Contributor

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? what is BC?
Deprecations? no
Documented? no
Fixed tickets #1106

Fixes the issue described in #1106

New Task Checklist:

  • Are the dependencies added to the composer.json suggestions? No
  • Is the doc/tasks.md file updated? N/A
  • Are the task parameters documented? N/A
  • Is the task registered in the tasks.yml file? N/A
  • Does the task contains phpunit tests? N/A
  • Is the configuration having logical allowed types? N/A
  • Does the task run in the correct context? N/A
  • Is the run() method readable? N/A
  • Is the run() method using the configuration correctly? N/A
  • Are all CI services returning green? Yes

@veewee
Copy link
Contributor

veewee commented Sep 14, 2023

Thanks @EwenQuim
It seems like the functional e2e tests pass in this pr.
The code looks good, but you need to alter the phpunit testcases for this task to match the new error messages.

@EwenQuim
Copy link
Contributor Author

EwenQuim commented Sep 14, 2023

Hi again @veewee .

It seems that the only difference between my changes and the existing version is that the newLines are replaced by a visible \n. Do you have any idea of what I did wrong ?

Also, I messed up amending my commits. Don't worry, it will be fixed when I'll be able to understand how to fix the tests. The PR should be OK after this, I think.

src/Task/Git/CommitMessage.php Show resolved Hide resolved
src/Task/Git/CommitMessage.php Outdated Show resolved Hide resolved
This feature is "prints commit message after its validation failed"
@EwenQuim EwenQuim changed the title wip: Prints error message when rejecting commit Prints error message when rejecting commit Sep 18, 2023
@veewee veewee added this to the 2.1.0 milestone Sep 19, 2023
@veewee veewee merged commit 9970720 into phpro:v2.x Sep 19, 2023
9 checks passed
@veewee
Copy link
Contributor

veewee commented Sep 19, 2023

Thanks again! :)

@EwenQuim
Copy link
Contributor Author

Thank you too!

When do you think a release will be made ?

@veewee
Copy link
Contributor

veewee commented Sep 19, 2023

Most likely at the end of the month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants