Revert "Allow to configure which hooks to run"

This reverts commit ee7707e.
phpro · May 26, 2024 · 426a6a5 · 426a6a5
1 parent 0c1245e
commit 426a6a5
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 22 deletions.
diff --git a/resources/config/config.yml b/resources/config/config.yml
@@ -20,7 +20,6 @@ services:
             - '%hooks_dir%'
             - '%hooks_preset%'
             - '%git_hook_variables%'
-            - '%git_hooks%'
     GrumPHP\Configuration\Model\ParallelConfig:
         factory: ['GrumPHP\Configuration\Model\ParallelConfig', 'fromArray']
         arguments:

diff --git a/src/Configuration/Configuration.php b/src/Configuration/Configuration.php
@@ -4,7 +4,6 @@
 
 namespace GrumPHP\Configuration;
 
-use GrumPHP\Console\Command\Git\InitCommand;
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
@@ -71,14 +70,6 @@ public function getConfigTreeBuilder(): TreeBuilder
         $ascii->children()->variableNode('failed')->defaultValue('grumphp-grumpy.txt');
         $ascii->children()->variableNode('succeeded')->defaultValue('grumphp-happy.txt');
 
-        $rootNode->children()->arrayNode('git_hooks')->defaultValue(InitCommand::$hooks)
-            ->prototype('scalar')
-                ->validate()
-                    ->ifNotInArray(InitCommand::$hooks)
-                    ->thenInvalid('Invalid item %s')
-                ->end()
-            ->end();
-
         // parallel
         $parallel = $rootNode->children()->arrayNode('parallel');
         $parallel->canBeDisabled();

diff --git a/src/Configuration/Model/HooksConfig.php b/src/Configuration/Model/HooksConfig.php
@@ -27,8 +27,7 @@ class HooksConfig
     public function __construct(
         ?string $dir,
         string $preset,
-        array $variables,
-        private array $gitHooks,
+        array $variables
     ) {
         $this->dir = $dir;
         $this->preset = $preset;
@@ -49,9 +48,4 @@ public function getVariables(): array
     {
         return $this->variables;
     }
-
-    public function getGitHooks(): array
-    {
-        return $this->gitHooks;
-    }
 }
diff --git a/src/Console/Command/Git/DeInitCommand.php b/src/Console/Command/Git/DeInitCommand.php
@@ -22,7 +22,6 @@ class DeInitCommand extends Command
      */
     protected static $hooks = [
         'pre-commit',
-        'pre-push',
         'commit-msg',
     ];
 

diff --git a/src/Console/Command/Git/InitCommand.php b/src/Console/Command/Git/InitCommand.php
@@ -27,7 +27,6 @@ class InitCommand extends Command
      */
     public static $hooks = [
         'pre-commit',
-        'pre-push',
         'commit-msg',
     ];
 
@@ -101,9 +100,6 @@ public function execute(InputInterface $input, OutputInterface $output): int
         }
 
         foreach (self::$hooks as $hook) {
-            if (!in_array($hook, $this->hooksConfig->getGitHooks(), true)) {
-                continue;
-            }
             $gitHook = $this->filesystem->buildPath($gitHooksPath, $hook);
             $hookTemplate = $this->filesystem->guessFile(
                 [