Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initial commit #3

wants to merge 1 commit into from

Conversation

zloyuser
Copy link
Collaborator

@zloyuser zloyuser commented Aug 6, 2019

No description provided.

@pronskiy
Copy link

pronskiy commented Aug 6, 2019

@wbars, could you help review please?

@wbars wbars self-requested a review August 6, 2019 11:09
@wbars
Copy link
Collaborator

wbars commented Aug 17, 2019

@zloyuser Hey! Just looked in the last master and don't quite get the idea of the plugin? Could you please give quick overview and specifically actual goal of the RedocServer? As far as I can see right now we only attach documents to the memory storage, but do no fetching - how this is supposed to be used? Aksing because just caching Documents can be dangerous because of memory leaks - better to fetch them in lazy manner since they will be cached by the platform. (see com.intellij.openapi.fileEditor.impl.FileDocumentManagerImpl#getDocument)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbars wbars Awaiting requested review from wbars

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zloyuser @pronskiy @wbars