Apiv1 fixes #34
Apiv1 fixes #34
Conversation
To allow testing to be restricted to a specific maximum API version. This allows new API tests to be skipped for old servers.
Conflicts: tests/test_base.py tests/test_framework.py
|
Let me look into the create/delete API before confirming your assumption. |
|
@jmathai: thanks, I raised a PR on the documentation to mark the tag create/delete endpoints as "Internal", since I'm not sure that they're actually useful for an API user. tag/create has no user-visible effect - the new tag doesn't appear in the tag list, since it's not associated with any photos. Better to just use photo/update?addTags. From memory, tag/delete doesn't remove the tags from each photo. Better to use photo/update?removeTags on each photo. I've left these endpoints defined in the python bindings for completeness, but perhaps it would actually be best to remove them to avoid confusion? |
|
@jmathai: is this still blocked? I think photo/documentation#14 might be a better place to continue the tag API discussion. |
|
As I suspected, the |
@jmathai: /tag/create.json is still present on the development branch. Are you sure you deleted it? What about /tag/delete.json - this also seems redundant - it apprears that tags can only be deleted by removing them from photos with photo/update.json. See also /photo/frontend#986, /photo/frontend#987, #38, /photo/documentation#14 |
Workarounds to support APIv1 properly.
Add OPENPHOTO_TEST_SERVER_API env var, to allow testing to be restricted to a specific maximum API version. This allows new API testcases to be skipped for old servers.
Explicitly remove tags from photos during tag testing. The tag create/delete API endpoints seem to be for internal use only, so these tests are a little contrived.