Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue256 - rss/atom feeds, WIP #771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

michelv
Copy link
Contributor

@michelv michelv commented Jun 18, 2012

Work in progress, it's better that more knowledgeable folks look into it now.

The idea is using the activity API for a feed ordered by descending upload date.

Among blocking problems in this pull request : feed-atom.php is used from the theme, photo sizes can't be customized in the feed, 304 support is non-existent.

@@ -84,6 +84,19 @@ public function photosUpload($write = true)
return $utilityObj->returnValue('/photos/upload', $write);
}

public function photosFeed($options = null, $feed_format = 'atom', $write = true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard this part, it's dead code. Sorry for including it in the pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a look yet but feel free to prune code and update the pull request if needed.

@jmathai
Copy link
Member

jmathai commented Jun 18, 2012

This looks really good. Give me a day or two to merge it in or ask questions!

@hfiguiere
Copy link
Member

awesome !!!

@@ -0,0 +1,46 @@
<?php echo '<'; ?>?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it looks weird: that's to avoid PHP short-tags problems. (There may be a prettier solution.)

@jmathai
Copy link
Member

jmathai commented Aug 20, 2012

@michelv Sorry I dropped the ball on this but what's remaining to merge this in?

@michelv
Copy link
Contributor Author

michelv commented Sep 12, 2012

Hi Jaisen. The most important thing remaining is putting feed-atom.php in src/templates/feed/atom.php which I didn't manage to do at the time of this PR, then making some markup for the feed item so that photos are nice enough in feed readers.
I'm not sure that I'll have time to do these remaining things, but I'll try.

@jmathai
Copy link
Member

jmathai commented Sep 12, 2012

@michelv Alright, I'll keep this in mind in case I have time to finish it off before you get to it.

@hfiguiere hfiguiere added this to the 5.0.0 milestone Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants