Allow the bytes per pixel to be forced in qoibench #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, QOI is a really exciting and interesting image format. Thanks for sharing your inspired code.
This update adds a --forcebpp # option to qoibench to allow the number of bytes per pixel to be forced to 3,4,etc. Also provides better logging on to QOI mismatches.
This change was made in development of on a version of a complementary QOI-inspired 1 byte per pixel greyscale encoding. It is here: https://github.com/jstavats/qoi/tree/adding_grey
I do machine vision, so speed is the most critical feature in lossless image compression. In that domain the majority of images are still greyscale, so I was inspired to come up with a greyscale version to that would complement your colour one.
Would you consider adding this greyscale implementation into QOI? The code and benchmarks results against the benchmark suite are in the repo above (for 1,3 and 4 byte per pixel encodings).
Keep up the awesome work!
Thanks, Jay