Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP debugging swapchain issue #10

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Conversation

schell
Copy link
Contributor

@schell schell commented Nov 4, 2022

Should help with debugging #9

@philpax
Copy link
Owner

philpax commented Nov 5, 2022

Thanks for the PR! I'd suggest using tracing instead of fast_log (the former is the de jure standard in the Rust ecosystem, as far as I know) and removing the vulkan_enable line - the spec says it's an alternative:

This extension is intended as an alternative to XR_KHR_vulkan_enable, and does not depend on it.

It could potentially cause conflicts with other runtimes.

@schell schell changed the title added logging to help debugging swapchain issue WIP debugging swapchain issue Nov 5, 2022
@schell
Copy link
Contributor Author

schell commented Nov 5, 2022

I've found that getting tracing, tracing-subscriber and tracing-log to work well with log to be a bit of a pain, which is why I use fast_log. fast_log gives you some nice filters that let you easily include or exclude logs produced by dependency crates without a bunch of configuration. Since wgpu uses log I've found it easier to go this route. I've been playing around with tracing-log to try to get the wgpu logs out in this branch but it just doesn't seem to be working. There's some magic invocation I'm sure, but it's not the problem I'd like to be working on.

@schell
Copy link
Contributor Author

schell commented Nov 5, 2022

Seems I had a bug that was panicking early, preventing wgpu from getting to print any logs after all! I'll switch to tracing for this.

@schell schell mentioned this pull request Nov 5, 2022
@philpax philpax merged commit 7f3a034 into philpax:main Nov 8, 2022
@philpax
Copy link
Owner

philpax commented Nov 8, 2022

Thanks for the PR, by the way! I took the liberty of merging it as the changes were pretty uncontroversial, even if we're still trying to figure out the issue 🙂

@schell schell deleted the swapchain_loading_#9 branch November 8, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants